Issue 8400068: Don't send omnibox bounds for hidden field trials.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8400068: Don't send omnibox bounds for hidden field trials. (Closed)

Created:
9 years, 1 month ago by sreeram

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Don't send omnibox bounds for hidden field trials. When the preview is finally shown in these field trials, the dropdown will always be closed, so this may help avoid some flicker. In the process, change IsHiddenExperiment() to include the SILENT experiment (helps eliminate some calls). BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107801

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -16 lines)			Patch
M	chrome/browser/instant/instant_controller.cc	View	6 chunks	+13 lines, -10 lines	0 comments	Download
M	chrome/browser/instant/instant_field_trial.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/instant/instant_field_trial.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/browser_options_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sreeram@chromium.org/8400068/1

9 years, 1 month ago (2011-10-28 20:33:38 UTC) #3

Change committed as 107801

Expand Messages | Collapse Messages