Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8400067: Fixes bug where windows weren't being moved and resized if the desktop (Closed)

Created:
9 years, 1 month ago by sky
Modified:
9 years, 1 month ago
Reviewers:
oshima
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fixes bug where windows weren't being moved and resized if the desktop size changed. BUG=none TEST=none R=oshima@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107797

Patch Set 1 #

Patch Set 2 : Tweaks #

Total comments: 3

Patch Set 3 : workspace->Activate() #

Total comments: 1

Patch Set 4 : Merge and incorporate feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -78 lines) Patch
M ui/aura_shell/aura_shell.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/aura_shell/default_container_layout_manager.h View 1 2 chunks +10 lines, -4 lines 0 comments Download
M ui/aura_shell/default_container_layout_manager_unittest.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M ui/aura_shell/shell.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ui/aura_shell/shell.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M ui/aura_shell/workspace/workspace.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/aura_shell/workspace/workspace.cc View 4 chunks +9 lines, -1 line 0 comments Download
A ui/aura_shell/workspace/workspace_controller.h View 1 1 chunk +56 lines, -0 lines 0 comments Download
A ui/aura_shell/workspace/workspace_controller.cc View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
M ui/aura_shell/workspace/workspace_manager.h View 1 2 3 4 chunks +5 lines, -9 lines 0 comments Download
M ui/aura_shell/workspace/workspace_manager.cc View 1 2 3 6 chunks +12 lines, -24 lines 0 comments Download
M ui/aura_shell/workspace/workspace_manager_unittest.cc View 8 chunks +32 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
9 years, 1 month ago (2011-10-28 18:19:27 UTC) #1
oshima
http://codereview.chromium.org/8400067/diff/1001/ui/aura_shell/workspace/workspace_controller.cc File ui/aura_shell/workspace/workspace_controller.cc (right): http://codereview.chromium.org/8400067/diff/1001/ui/aura_shell/workspace/workspace_controller.cc#newcode42 ui/aura_shell/workspace/workspace_controller.cc:42: workspace_manager_->SetActiveWorkspace(workspace); workspace->Activate(); http://codereview.chromium.org/8400067/diff/1001/ui/aura_shell/workspace/workspace_manager_unittest.cc File ui/aura_shell/workspace/workspace_manager_unittest.cc (right): http://codereview.chromium.org/8400067/diff/1001/ui/aura_shell/workspace/workspace_manager_unittest.cc#newcode123 ui/aura_shell/workspace/workspace_manager_unittest.cc:123: TEST_F(WorkspaceManagerTest, ...
9 years, 1 month ago (2011-10-28 18:38:23 UTC) #2
sky
http://codereview.chromium.org/8400067/diff/1001/ui/aura_shell/workspace/workspace_manager_unittest.cc File ui/aura_shell/workspace/workspace_manager_unittest.cc (right): http://codereview.chromium.org/8400067/diff/1001/ui/aura_shell/workspace/workspace_manager_unittest.cc#newcode123 ui/aura_shell/workspace/workspace_manager_unittest.cc:123: TEST_F(WorkspaceManagerTest, DISABLED_Overview) { On 2011/10/28 18:38:23, oshima wrote: > ...
9 years, 1 month ago (2011-10-28 19:14:08 UTC) #3
sky
I uploaded a new patch that changes WorkspaceController::OnActiveWindowChanged. -Scott
9 years, 1 month ago (2011-10-28 19:15:21 UTC) #4
oshima
LGTM with one comment. http://codereview.chromium.org/8400067/diff/4001/ui/aura_shell/workspace/workspace_manager.h File ui/aura_shell/workspace/workspace_manager.h (right): http://codereview.chromium.org/8400067/diff/4001/ui/aura_shell/workspace/workspace_manager.h#newcode41 ui/aura_shell/workspace/workspace_manager.h:41: void SetActiveWorkspace(Workspace* workspace); We can ...
9 years, 1 month ago (2011-10-28 20:27:20 UTC) #5
sky
9 years, 1 month ago (2011-10-28 21:21:53 UTC) #6 
On Fri, Oct 28, 2011 at 1:27 PM,  <oshima@chromium.org> wrote:
> LGTM with one comment.
>
>
>
http://codereview.chromium.org/8400067/diff/4001/ui/aura_shell/workspace/work...
> File ui/aura_shell/workspace/workspace_manager.h (right):
>
>
http://codereview.chromium.org/8400067/diff/4001/ui/aura_shell/workspace/work...
> ui/aura_shell/workspace/workspace_manager.h:41: void
> SetActiveWorkspace(Workspace* workspace);
> We can move this back to private?

Done.

  -Scott

Powered by Google App Engine
This is Rietveld 408576698