Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1346)

Unified Diff: ui/aura/window.h

Issue 8400063: Move maximize/fullscreen/restore to shell (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove OVERRIDE from .cc Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/toplevel_window_event_filter_unittest.cc ('k') | ui/aura/window.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/window.h
diff --git a/ui/aura/window.h b/ui/aura/window.h
index 8e53aadec73c699a092c3e105b1b85899f46a15e..ed261b479982a67fb657f778fe0ee6c0ff304255 100644
--- a/ui/aura/window.h
+++ b/ui/aura/window.h
@@ -14,7 +14,6 @@
#include "base/observer_list.h"
#include "base/string16.h"
#include "ui/base/events.h"
-#include "ui/base/ui_base_types.h"
#include "ui/aura/aura_export.h"
#include "ui/aura/window_types.h"
#include "ui/gfx/compositor/layer.h"
@@ -94,21 +93,9 @@ class AURA_EXPORT Window : public ui::LayerDelegate {
// Returns true if this window and all its ancestors are visible.
bool IsVisible() const;
- // Maximize the window.
- void Maximize();
-
- // Go into fullscreen mode.
- void Fullscreen();
-
- // Restore the window to its original bounds.
- void Restore();
-
// Returns the window's bounds in screen coordinates.
gfx::Rect GetScreenBounds() const;
- // Returns the window's show state.
- ui::WindowShowState show_state() const { return show_state_; }
-
// Activates this window. Only top level windows can be activated. Requests
// to activate a non-top level window are ignored.
void Activate();
@@ -263,17 +250,19 @@ class AURA_EXPORT Window : public ui::LayerDelegate {
// IsToplevelWindowContainer.
Window* GetToplevelWindow();
- // Returns true if this window is fullscreen or contains a fullscreen window.
- bool IsOrContainsFullscreenWindow() const;
-
- // Sets the window property |value| for given |name|. Setting NULL
+ // Sets the window property |value| for given |name|. Setting NULL or 0
// removes the property. It uses |ui::ViewProp| to store the property.
// Please see the description of |prop_map_| for more details.
void SetProperty(const char* name, void* value);
+ void SetIntProperty(const char* name, int value);
- // Returns the window property for given |name|. Returns NULL if
+ // Returns the window property for given |name|. Returns NULL or 0 if
// the property does not exist.
+ // TODO(oshima): Returning 0 for non existing property is problematic.
+ // Fix ViewProp to be able to tell if the property exists and
+ // change it to -1.
void* GetProperty(const char* name) const;
+ int GetIntProperty(const char* name) const;
protected:
// Returns the desktop or NULL if we aren't yet attached to a desktop.
@@ -296,10 +285,6 @@ class AURA_EXPORT Window : public ui::LayerDelegate {
// it in the z-order.
bool StopsEventPropagation() const;
- // Update the show state and restore bounds. Returns false
- // if |new_show_state| is same as current show state.
- bool UpdateShowStateAndRestoreBounds(ui::WindowShowState new_show_state);
-
// Gets a Window (either this one or a subwindow) containing |local_point|.
// If |return_tightest| is true, returns the tightest-containing (i.e.
// furthest down the hierarchy) Window containing the point; otherwise,
@@ -319,8 +304,6 @@ class AURA_EXPORT Window : public ui::LayerDelegate {
WindowDelegate* delegate_;
- ui::WindowShowState show_state_;
-
// The original bounds of a maximized/fullscreen window.
gfx::Rect restore_bounds_;
« no previous file with comments | « ui/aura/toplevel_window_event_filter_unittest.cc ('k') | ui/aura/window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698