IndexedDB: Recycle cursor objects when calling continue().

content/renderer/indexed_db_dispatcher.h

Index: content/renderer/indexed_db_dispatcher.h
diff --git a/content/renderer/indexed_db_dispatcher.h b/content/renderer/indexed_db_dispatcher.h
index e30fa95df5003552bab12d521b3746b69229568f..0b033493e535ecded0cc9d32cd3cb042872ad09a 100644
--- a/content/renderer/indexed_db_dispatcher.h
+++ b/content/renderer/indexed_db_dispatcher.h
@@ -14,6 +14,7 @@
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBDatabase.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBObjectStore.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBTransactionCallbacks.h"
+#include <map>

[michaeln, 2011/11/03 18:10:04]

we generally like to put std includes up top followed by a blank line, and then
the other includes

[hans, 2011/11/04 10:09:44]

Done.

 
 class IndexedDBKey;
 
@@ -28,6 +29,8 @@ namespace content {
 class SerializedScriptValue;
 }
 
+class RendererWebIDBCursorImpl;

[michaeln, 2011/11/03 18:10:04]

nit: this forward should be up by class IndexedDBKey forward

[hans, 2011/11/04 10:09:44]

Done.

+
 // Handle the indexed db related communication for this entire renderer.
 class IndexedDBDispatcher : public IPC::Channel::Listener {
  public:
@@ -153,6 +156,8 @@ class IndexedDBDispatcher : public IPC::Channel::Listener {
 
   static int32 TransactionId(const WebKit::WebIDBTransaction& transaction);
 
+  void CursorDestroyed(int32 cursor_id);

[michaeln, 2011/11/03 18:10:04]

nit: since the previous method is 'static', can you put this instance method
before to keep it with the other instance methods

[hans, 2011/11/04 10:09:44]

Done.

+
  private:
   // IDBCallback message handlers.
   void OnSuccessNull(int32 response_id);
@@ -163,6 +168,11 @@ class IndexedDBDispatcher : public IPC::Channel::Listener {
                            const IndexedDBKey& key,
                            const IndexedDBKey& primary_key,
                            const content::SerializedScriptValue& value);
+  void OnSuccessCursorContinue(int32 response_id,
+                               int32 cursor_id,
+                               const IndexedDBKey& key,
+                               const IndexedDBKey& primary_key,
+                               const content::SerializedScriptValue& value);
   void OnSuccessStringList(int32 response_id,
                            const std::vector<string16>& value);
   void OnSuccessSerializedScriptValue(
@@ -182,6 +192,9 @@ class IndexedDBDispatcher : public IPC::Channel::Listener {
   IDMap<WebKit::WebIDBDatabaseCallbacks, IDMapOwnPointer>
       pending_database_callbacks_;
 
+  // Map from cursor id to RendererWebIDBCursorImpl.
+  std::map<int32, RendererWebIDBCursorImpl*> cursors_;
+
   DISALLOW_COPY_AND_ASSIGN(IndexedDBDispatcher);
 };