IndexedDB: Recycle cursor objects when calling continue().

content/browser/in_process_webkit/indexed_db_callbacks.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/in_process_webkit/indexed_db_callbacks.h"
 
 #include "content/common/indexed_db_messages.h"
 #include "webkit/quota/quota_manager.h"
 
 IndexedDBCallbacksBase::IndexedDBCallbacksBase(
@@ skipping 23 matching lines @@
       content::SerializedScriptValue(idb_object->value())));
 }
 
 void IndexedDBCallbacks<WebKit::WebIDBCursor>::onSuccess(
     const WebKit::WebSerializedScriptValue& value) {
   dispatcher_host()->Send(
       new IndexedDBMsg_CallbacksSuccessSerializedScriptValue(
           response_id(), content::SerializedScriptValue(value)));
 }
 
+void IndexedDBCallbacks<WebKit::WebIDBCursor>::onSuccessCursorContinue() {
+  DCHECK(cursor_id_ != -1);
+  WebKit::WebIDBCursor* idb_cursor = dispatcher_host()->getCursorFromId(
+      cursor_id_);
+

[michaeln, 2011/10/31 18:58:25]

should we be more defensive here...

DCHECK(idb_cursor);
if (!idb_cursor)
  return;

[hans, 2011/11/01 14:57:45]

Yes, let's do this.

+  dispatcher_host()->Send(
+      new IndexedDBMsg_CallbacksSuccessCursorContinue(
+          response_id(),
+          cursor_id_,
+          IndexedDBKey(idb_cursor->key()),
+          IndexedDBKey(idb_cursor->primaryKey()),
+          content::SerializedScriptValue(idb_cursor->value())));
+}
+
 void IndexedDBCallbacks<WebKit::WebIDBKey>::onSuccess(
     const WebKit::WebIDBKey& value) {
   dispatcher_host()->Send(
       new IndexedDBMsg_CallbacksSuccessIndexedDBKey(
           response_id(), IndexedDBKey(value)));
 }
 
 void IndexedDBCallbacks<WebKit::WebDOMStringList>::onSuccess(
     const WebKit::WebDOMStringList& value) {
 
   std::vector<string16> list;
   for (unsigned i = 0; i < value.length(); ++i)
       list.push_back(value.item(i));
 
   dispatcher_host()->Send(
       new IndexedDBMsg_CallbacksSuccessStringList(
           response_id(), list));
 }
 
 void IndexedDBCallbacks<WebKit::WebSerializedScriptValue>::onSuccess(
     const WebKit::WebSerializedScriptValue& value) {
   dispatcher_host()->Send(
       new IndexedDBMsg_CallbacksSuccessSerializedScriptValue(
           response_id(), content::SerializedScriptValue(value)));
 }