IndexedDB: Recycle cursor objects when calling continue().

content/renderer/renderer_webidbcursor_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDERER_WEBIDBCURSOR_IMPL_H_
 #define CONTENT_RENDERER_RENDERER_WEBIDBCURSOR_IMPL_H_
 
 #include "base/basictypes.h"
 #include "content/common/indexed_db_key.h"
 #include "content/public/common/serialized_script_value.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBCallbacks.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBCursor.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBKey.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebSerializedScriptValue.h"
 
 class RendererWebIDBCursorImpl : public WebKit::WebIDBCursor {
  public:
-  RendererWebIDBCursorImpl(int32 idb_cursor_id, const IndexedDBKey& key,
-                           const IndexedDBKey& primary_key,
-                           const content::SerializedScriptValue& value);
+  RendererWebIDBCursorImpl(int32 idb_cursor_id);
   virtual ~RendererWebIDBCursorImpl();
 
   virtual unsigned short direction() const;
   virtual WebKit::WebIDBKey key() const;
   virtual WebKit::WebIDBKey primaryKey() const;
   virtual WebKit::WebSerializedScriptValue value() const;
   virtual void update(const WebKit::WebSerializedScriptValue& value,
                       WebKit::WebIDBCallbacks* callback,
                       WebKit::WebExceptionCode& ec);
   virtual void continueFunction(const WebKit::WebIDBKey& key,
                                 WebKit::WebIDBCallbacks* callback,
                                 WebKit::WebExceptionCode& ec);
   virtual void deleteFunction(WebKit::WebIDBCallbacks* callback,
                               WebKit::WebExceptionCode& ec);
 
+  void setKeyAndValue(const IndexedDBKey& key, const IndexedDBKey& primary_key,

[michaeln, 2011/11/01 18:38:37]

since this isn't defined in the WebKitAPI, please use a chromium-style upper
cased method name

[hans, 2011/11/02 17:16:58]

Done.

+                      const content::SerializedScriptValue& value);
+
  private:
   int32 idb_cursor_id_;
-  const IndexedDBKey key_;
-  const IndexedDBKey primary_key_;
-  const content::SerializedScriptValue value_;
+  IndexedDBKey key_;
+  IndexedDBKey primary_key_;
+  content::SerializedScriptValue value_;
 };
 
 #endif  // CONTENT_RENDERER_RENDERER_WEBIDBCURSOR_IMPL_H_