Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Issue 8400060: Switch content tests to use BrowserThreadImpl directly. (Closed)

Created:
9 years, 1 month ago by Jói
Modified:
9 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, michaeln, hclam+watch_chromium.org, Avi (use Gerrit), James Su, creis+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, ajwong+watch_chromium.org, jam, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., vrk (LEFT CHROMIUM), brettw-cc_chromium.org, scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Switch content tests to use BrowserThreadImpl directly. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107964

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comment. #

Patch Set 3 : Merge to lkgr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -87 lines) Patch
M content/browser/appcache/chrome_appcache_service_unittest.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M content/browser/download/base_file_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/download/download_file_unittest.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/download/download_id_unittest.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/download/save_package_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/geolocation/gps_location_provider_unittest_linux.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/dom_storage_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/in_process_webkit/webkit_context_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/plugin_loader_posix_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_device_manager_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 3 chunks +9 lines, -7 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_unittest.cc View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M content/browser/renderer_host/resource_queue_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/resolve_proxy_msg_helper_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/site_instance_unittest.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/speech/speech_recognizer_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager_unittest.cc View 6 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jói
I wanted your opinion on the using clauses before committing. It seems to me that ...
9 years, 1 month ago (2011-10-28 13:40:54 UTC) #1
jam
lgtm This is the approach I've tried to use as well. Even in chrome code, ...
9 years, 1 month ago (2011-10-28 17:00:21 UTC) #2
Jói
http://codereview.chromium.org/8400060/diff/1/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm File content/browser/renderer_host/render_widget_host_view_mac_unittest.mm (right): http://codereview.chromium.org/8400060/diff/1/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm#newcode91 content/browser/renderer_host/render_widget_host_view_mac_unittest.mm:91: scoped_ptr<content::BrowserThreadImpl> ui_thread_( On 2011/10/28 17:00:21, John Abd-El-Malek wrote: > ...
9 years, 1 month ago (2011-10-31 15:13:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8400060/6001
9 years, 1 month ago (2011-10-31 15:13:23 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-10-31 16:28:05 UTC) #5
Change committed as 107964

Powered by Google App Engine
This is Rietveld 408576698