Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 8400056: Fix assertSame for unit testing harness. (Closed)

Created:
9 years, 1 month ago by Michael Starzinger
Modified:
9 years, 1 month ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Fix assertSame for unit testing harness. Using isNaN() here is bogus because it performs an implicit toNumber() conversion, hence something like assertSame(undefined, {}) would not throw an exception. These are not the NaNs you are looking for. R=rossberg@chromium.org TEST=mjsunit Committed: http://code.google.com/p/v8/source/detail?r=9831

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M test/mjsunit/mjsunit.js View 1 chunk +1 line, -1 line 1 comment Download
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
PTAL.
9 years, 1 month ago (2011-10-28 08:26:41 UTC) #1
rossberg
9 years, 1 month ago (2011-10-28 09:05:18 UTC) #2
Aargh!

LGTM

http://codereview.chromium.org/8400056/diff/1/test/mjsunit/mjsunit.js
File test/mjsunit/mjsunit.js (right):

http://codereview.chromium.org/8400056/diff/1/test/mjsunit/mjsunit.js#newcode226
test/mjsunit/mjsunit.js:226: } else if ((expected !== expected) && (found !==
found)) {
Somebody should pull IEEE to court for their NaN semantics.
Somebody should also pull to court the person responsible for the semantics of
isNaN in JavaScript.

http://codereview.chromium.org/8400056/diff/1/test/mjsunit/mjsunit.status
File test/mjsunit/mjsunit.status (right):

http://codereview.chromium.org/8400056/diff/1/test/mjsunit/mjsunit.status#new...
test/mjsunit/mjsunit.status:35: harmony/proxies-function: FAIL
Damn, just when you think that everything is working...

Powered by Google App Engine
This is Rietveld 408576698