Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 8400050: Include the HTTP status code as a feature in the ClientPhishingRequest. (Closed)

Created:
9 years, 1 month ago by Brian Ryner
Modified:
9 years, 1 month ago
Reviewers:
noelutz, mattm
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Include the HTTP status code as a feature in the ClientPhishingRequest. BUG=none TEST=BrowserFeatureExtractorTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/browser/safe_browsing/browser_feature_extractor.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/browser_features.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/browser_features.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Brian Ryner
9 years, 1 month ago (2011-10-28 02:31:55 UTC) #1
mattm
lgtm
9 years, 1 month ago (2011-10-28 03:04:05 UTC) #2
noelutz
lgtm
9 years, 1 month ago (2011-10-28 16:37:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryner@chromium.org/8400050/1
9 years, 1 month ago (2011-10-28 17:49:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryner@chromium.org/8400050/1
9 years, 1 month ago (2011-10-29 06:42:06 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-10-29 08:00:46 UTC) #6
Change committed as 107867

Powered by Google App Engine
This is Rietveld 408576698