Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 8400046: Roll gyp DEPS to gyp ToT. (Closed)

Created:
9 years, 1 month ago by tony
Modified:
9 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Roll gyp DEPS to gyp ToT. This includes the following changes: r1083: make: support more shell variations r1082: Ninja: substitute RULE_INPUT_PATH and ExpandSpecial for cflags BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tony
9 years, 1 month ago (2011-10-27 23:42:17 UTC) #1
Nico
LGTM Usually we just do one-line-per-change summaries in gyp rolls: http://svnsearch.org/svnsearch/repos/CHROMIUM/search?logMessage=roll%20gyp
9 years, 1 month ago (2011-10-27 23:52:53 UTC) #2
tony
On 2011/10/27 23:52:53, Nico wrote: > LGTM > > Usually we just do one-line-per-change summaries ...
9 years, 1 month ago (2011-10-27 23:55:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/8400046/1
9 years, 1 month ago (2011-10-28 16:38:58 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-10-28 18:28:57 UTC) #5
Change committed as 107759

Powered by Google App Engine
This is Rietveld 408576698