Issue 8400044: Associate the instant label text with a specific checkbox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8400044: Associate the instant label text with a specific checkbox. (Closed)

Created:
9 years, 1 month ago by sreeram

Modified:
9 years, 1 month ago

Reviewers:
Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews), James Hawkins, stuartmorgan

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Associate the instant label text with a specific checkbox. I've tested this using all combinations of field trials (both naturally selected as well as forced through the --instant-field-trial commandline switch), and everything works as expected. BUG=101930 TEST=Clicking on the label text should turn the checkbox on/off. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107818

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/resources/options/browser_options.html	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/resources/options/browser_options.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sreeram

Please review. @jhawkins, @stuartmorgan: If you'd like to review, please go ahead, too.

9 years, 1 month ago (2011-10-27 23:08:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sreeram@chromium.org/8400044/1

9 years, 1 month ago (2011-10-28 21:16:44 UTC) #3

Change committed as 107818

Expand Messages | Collapse Messages