runtime/bin/socket_stream.dart - Issue 8400038: Use strict equality when comparing with null, especially when null is a default value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket_stream.dart

Issue 8400038: Use strict equality when comparing with null, especially when null is a default value. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/socket_stream.dart

===================================================================

--- runtime/bin/socket_stream.dart (revision 855)

+++ runtime/bin/socket_stream.dart (working copy)

@@ -29,8 +29,8 @@

}

int readInto(List<int> buffer, int offset, int len) {

- if (offset == null) offset = 0;

- if (len == null) len = buffer.length;

+ if (offset === null) offset = 0;

+ if (len === null) len = buffer.length;

if (offset < 0) throw new StreamException("Illegal offset $offset");

if (len < 0) throw new StreamException("Illegal length $len");

return _socket.readList(buffer, offset, len);

« no previous file with comments | « runtime/bin/socket_impl.dart ('k') | runtime/bin/string_stream.dart » ('j') | no next file with comments »