Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 8400034: chromeos: Add a stub implementation for SensorsSource. (Closed)

Created:
9 years, 1 month ago by satorux1
Modified:
9 years, 1 month ago
Reviewers:
cwolfe
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Add a stub implementation for SensorsSource. Along the way, rename the class to SensorsClient, to be consistent with other classes in the directory, and do some minor cleanup. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -135 lines) Patch
M chrome/browser/chromeos/dbus/dbus_thread_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/dbus/dbus_thread_manager.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/dbus/power_manager_client.h View 1 chunk +5 lines, -1 line 0 comments Download
A chrome/browser/chromeos/dbus/sensors_client.h View 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/dbus/sensors_client.cc View 1 chunk +99 lines, -0 lines 0 comments Download
D chrome/browser/chromeos/dbus/sensors_source.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/chromeos/dbus/sensors_source.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/browser/chromeos/dbus/speech_synthesizer_client.h View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/chromeos/dbus/speech_synthesizer_client.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
satorux1
9 years, 1 month ago (2011-10-27 19:58:59 UTC) #1
cwolfe
9 years, 1 month ago (2011-10-27 20:03:31 UTC) #2
Took a read through, LGTM.

Powered by Google App Engine
This is Rietveld 408576698