Add code to prompt for browser login during app notification setup

Add code to prompt for browser login during app notification setup

BUG=98145
TEST=Start not signed in to sync, and install an app with the 'experimental'
permission. Then visit a page in the app which calls
chrome.app.experimental.getNotificationChannel({clientId:"foo"}) - you should
get an infobar asking you to sign in.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107800

[Mihai Parparita -not on Chrome, 2011-10-27 22:21:05]

LGTM

http://codereview.chromium.org/8400027/diff/1/chrome/browser/extensions/app_n...
File chrome/browser/extensions/app_notify_channel_setup.cc (right):

http://codereview.chromium.org/8400027/diff/1/chrome/browser/extensions/app_n...
chrome/browser/extensions/app_notify_channel_setup.cc:98: std::string code;
You don't seem to be using these variables.

http://codereview.chromium.org/8400027/diff/1/chrome/browser/extensions/app_n...
File chrome/browser/extensions/app_notify_channel_ui.cc (right):

http://codereview.chromium.org/8400027/diff/1/chrome/browser/extensions/app_n...
chrome/browser/extensions/app_notify_channel_ui.cc:94: if (observing_sync_)
Can this happen? In AppNotifyChannelSetup::Start you call AddRef() before the 
PromptSyncSetup call, so it seems like there's no way for this object to be
deleted before we stop observing sync and call back the delegate.

A CHECK(!observing_sync_) may be more appropriate.

http://codereview.chromium.org/8400027/diff/1/chrome/browser/extensions/app_n...
File chrome/browser/extensions/app_notify_channel_ui.h (right):

http://codereview.chromium.org/8400027/diff/1/chrome/browser/extensions/app_n...
chrome/browser/extensions/app_notify_channel_ui.h:46: // A private class we use
to put up an infobar - it's lifetime is managed by
Typo (it's -> its).

[asargent_no_longer_on_chrome, 2011-10-28 17:09:21]

http://codereview.chromium.org/8400027/diff/1/chrome/browser/extensions/app_n...
File chrome/browser/extensions/app_notify_channel_setup.cc (right):

http://codereview.chromium.org/8400027/diff/1/chrome/browser/extensions/app_n...
chrome/browser/extensions/app_notify_channel_setup.cc:98: std::string code;
On 2011/10/27 22:21:05, Mihai Parparita wrote:
> You don't seem to be using these variables.
Oops, good catch - I had moved them to be inline in the base::Bind call below,
and forgot to remove them here. Done.

http://codereview.chromium.org/8400027/diff/1/chrome/browser/extensions/app_n...
File chrome/browser/extensions/app_notify_channel_ui.cc (right):

http://codereview.chromium.org/8400027/diff/1/chrome/browser/extensions/app_n...
chrome/browser/extensions/app_notify_channel_ui.cc:94: if (observing_sync_)
On 2011/10/27 22:21:05, Mihai Parparita wrote:
> Can this happen? In AppNotifyChannelSetup::Start you call AddRef() before the 
> PromptSyncSetup call, so it seems like there's no way for this object to be
> deleted before we stop observing sync and call back the delegate.
> 
> A CHECK(!observing_sync_) may be more appropriate.

Good point. Done.

http://codereview.chromium.org/8400027/diff/1/chrome/browser/extensions/app_n...
File chrome/browser/extensions/app_notify_channel_ui.h (right):

http://codereview.chromium.org/8400027/diff/1/chrome/browser/extensions/app_n...
chrome/browser/extensions/app_notify_channel_ui.h:46: // A private class we use
to put up an infobar - it's lifetime is managed by
On 2011/10/27 22:21:05, Mihai Parparita wrote:
> Typo (it's -> its).

Done.

[commit-bot: I haz the power, 2011-10-28 17:09:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asargent@chromium.org/8400027/4001

[commit-bot: I haz the power, 2011-10-28 18:06:39]

Try job failure for 8400027-4001 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2011-10-28 18:37:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asargent@chromium.org/8400027/4002

[commit-bot: I haz the power, 2011-10-28 21:49:00]

Change committed as 107800