Issue 8400020: Revert 107528 - Collect some histograms about signed binary downloads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8400020: Revert 107528 - Collect some histograms about signed binary downloads. (Closed)

Created:
9 years, 1 month ago by Brian Ryner

Modified:
9 years, 1 month ago

Reviewers:
Brian Ryner

CC:
chromium-reviews, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 107528 - Collect some histograms about signed binary downloads. This hooks up the DownloadProtectionService to run after a download finishes. For now, this does not send a download pingback since the flag defaults to off. TEST=DownloadProtectionServiceTest BUG=none Review URL: http://codereview.chromium.org/8345033 TBR=bryner@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107538

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+234 lines, -572 lines)			Patch
M	chrome/browser/download/chrome_download_manager_delegate.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/download/chrome_download_manager_delegate.cc	View	2 chunks	+1 line, -26 lines	0 comments	Download
M	chrome/browser/safe_browsing/client_side_detection_host_unittest.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/safe_browsing/download_protection_service.h	View	5 chunks	+48 lines, -34 lines	0 comments	Download
M	chrome/browser/safe_browsing/download_protection_service.cc	View	3 chunks	+135 lines, -275 lines	0 comments	Download
M	chrome/browser/safe_browsing/download_protection_service_unittest.cc	View	11 chunks	+28 lines, -102 lines	0 comments	Download
	chrome/browser/safe_browsing/safe_browsing_service.h	View	5 chunks	+3 lines, -8 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_service.cc	View	4 chunks	+18 lines, -9 lines	0 comments	Download
D	chrome/browser/safe_browsing/signature_util.h	View	1 chunk	+0 lines, -24 lines	0 comments	Download
D	chrome/browser/safe_browsing/signature_util_posix.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	chrome/browser/safe_browsing/signature_util_win.cc	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	chrome/browser/safe_browsing/signature_util_win_unittest.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages