Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issue 8400014: Fix visibility on WebLayer (Closed)

Created:
9 years, 1 month ago by piman
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, jonathan.backer
Visibility:
Public.

Description

Fix visibility on WebLayer A change in the UI code exposed this bug where we were not setting the opacity properly on the web layer in certain cases. BUG=None TEST=chrome/aura Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107627

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M ui/gfx/compositor/layer.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/compositor/layer_unittest.cc View 1 2 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
piman
9 years, 1 month ago (2011-10-27 02:24:27 UTC) #1
jonathan.backer
lgtm
9 years, 1 month ago (2011-10-27 12:02:56 UTC) #2
Ben Goodger (Google)
LGTM2
9 years, 1 month ago (2011-10-27 15:30:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8400014/4001
9 years, 1 month ago (2011-10-27 16:34:05 UTC) #4
commit-bot: I haz the power
Try job failure for 8400014-4001 (retry) (retry) on linux_rel for step "ui_tests". It's a second ...
9 years, 1 month ago (2011-10-27 18:06:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8400014/4001
9 years, 1 month ago (2011-10-27 18:29:25 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-10-27 21:27:51 UTC) #7
Change committed as 107627

Powered by Google App Engine
This is Rietveld 408576698