Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: Source/WebCore/rendering/RenderBlock.cpp

Issue 8399045: Merge 98561 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/912/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/css/nested-first-letter-with-float-crash-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 5538 matching lines...) Expand 10 before | Expand all | Expand 10 after
5549 if (currChild->isListMarker()) 5549 if (currChild->isListMarker())
5550 currChild = currChild->nextSibling(); 5550 currChild = currChild->nextSibling();
5551 else if (currChild->isFloatingOrPositioned()) { 5551 else if (currChild->isFloatingOrPositioned()) {
5552 if (currChild->style()->styleType() == FIRST_LETTER) { 5552 if (currChild->style()->styleType() == FIRST_LETTER) {
5553 currChild = currChild->firstChild(); 5553 currChild = currChild->firstChild();
5554 break; 5554 break;
5555 } 5555 }
5556 currChild = currChild->nextSibling(); 5556 currChild = currChild->nextSibling();
5557 } else if (currChild->isReplaced() || currChild->isRenderButton() || cur rChild->isMenuList()) 5557 } else if (currChild->isReplaced() || currChild->isRenderButton() || cur rChild->isMenuList())
5558 break; 5558 break;
5559 else if (currChild->style()->hasPseudoStyle(FIRST_LETTER) && currChild-> canHaveChildren()) {
5560 // We found a lower-level node with first-letter, which supersedes t he higher-level style
5561 firstLetterBlock = currChild;
5562 currChild = currChild->firstChild();
5563 }
5559 else 5564 else
5560 currChild = currChild->firstChild(); 5565 currChild = currChild->firstChild();
5561 } 5566 }
5562 5567
5563 if (!currChild) 5568 if (!currChild)
5564 return; 5569 return;
5565 5570
5566 // If the child already has style, then it has already been created, so we j ust want 5571 // If the child already has style, then it has already been created, so we j ust want
5567 // to update it. 5572 // to update it.
5568 if (currChild->parent()->style()->styleType() == FIRST_LETTER) { 5573 if (currChild->parent()->style()->styleType() == FIRST_LETTER) {
(...skipping 1325 matching lines...) Expand 10 before | Expand all | Expand 10 after
6894 } 6899 }
6895 6900
6896 String ValueToString<RenderBlock::FloatingObject*>::string(const RenderBlock::Fl oatingObject* floatingObject) 6901 String ValueToString<RenderBlock::FloatingObject*>::string(const RenderBlock::Fl oatingObject* floatingObject)
6897 { 6902 {
6898 return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->x( ), floatingObject->y(), floatingObject->maxX(), floatingObject->maxY()); 6903 return String::format("%p (%dx%d %dx%d)", floatingObject, floatingObject->x( ), floatingObject->y(), floatingObject->maxX(), floatingObject->maxY());
6899 } 6904 }
6900 6905
6901 #endif 6906 #endif
6902 6907
6903 } // namespace WebCore 6908 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/css/nested-first-letter-with-float-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698