Issue 8399044: aura: Make sure the desktop widget gets parented to the correct container.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8399044: aura: Make sure the desktop widget gets parented to the correct container. (Closed)

Created:
9 years, 1 month ago by sadrul

Modified:
9 years, 1 month ago

Reviewers:
Ben Goodger (Google), sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

aura: Make sure the desktop widget gets parented to the correct container, and is of correct type. This fixes these issue: . clicking on the desktop window ends up shrinking the desktop itself. . the desktop window gets in front of the chrome window on startup. . crash when mousewheeling on the desktop. Also check for NULL active_workspace_ to avoid a crash when clicking on an empty desktop. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107594

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
M	ui/aura_shell/desktop_background_view.cc	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	ui/aura_shell/examples/lock_view.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/aura_shell/workspace/workspace_manager.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sadrul

The desktop widget also needs to be a toplevel Widget to have a FocusManager. Otherwise ...

9 years, 1 month ago (2011-10-27 17:02:51 UTC) #2

sadrul

Also added a crash fix for a second-click on an empty desktop.

9 years, 1 month ago (2011-10-27 17:14:10 UTC) #3

LGTM

Expand Messages | Collapse Messages