Issue 8399028: base::Bind: Convert chrome/browser/profiles.

Issue 8399028: base::Bind: Convert chrome/browser/profiles. (Closed)

Created:
9 years, 1 month ago by James Hawkins

Modified:
9 years, 1 month ago

Reviewers:
csilv

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

base::Bind: Convert chrome/browser/profiles. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107881

Patch Set 4 : More win fox. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -53 lines)			Patch
M	chrome/browser/profiles/off_the_record_profile_impl.cc	View	1 2	5 chunks	+13 lines, -16 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	1 2 3	10 chunks	+31 lines, -32 lines	0 comments	Download
M	chrome/browser/profiles/profile_io_data.cc	View	1 2 3	2 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

csilv

lgtm http://codereview.chromium.org/8399028/diff/3001/chrome/browser/profiles/profile_impl.cc File chrome/browser/profiles/profile_impl.cc (right): http://codereview.chromium.org/8399028/diff/3001/chrome/browser/profiles/profile_impl.cc#newcode161 chrome/browser/profiles/profile_impl.cc:161: // function with non-void return type. If you ...

9 years, 1 month ago (2011-10-28 22:28:53 UTC) #2

James Hawkins

http://codereview.chromium.org/8399028/diff/3001/chrome/browser/profiles/profile_impl.cc File chrome/browser/profiles/profile_impl.cc (right): http://codereview.chromium.org/8399028/diff/3001/chrome/browser/profiles/profile_impl.cc#newcode161 chrome/browser/profiles/profile_impl.cc:161: // function with non-void return type. On 2011/10/28 22:28:53, ...

9 years, 1 month ago (2011-10-28 23:03:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhawkins@chromium.org/8399028/7004

9 years, 1 month ago (2011-10-29 18:24:54 UTC) #4

commit-bot: I haz the power

9 years, 1 month ago (2011-10-29 18:24:56 UTC) #5

Presubmit check for 8399028-7004 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/profiles/off_the_record_profile_impl.cc,chrome/browser/profiles/profile_impl.cc,chrome/browser/profiles/profile_io_data.cc

Expand Messages | Collapse Messages