Issue 8399027: Makes overview center the active workspace. This avoids leaving extra

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8399027: Makes overview center the active workspace. This avoids leaving extra (Closed)

Created:
9 years, 1 month ago by sky

Modified:
9 years, 1 month ago

Reviewers:
oshima

CC:
chromium-reviews, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Makes overview center the active workspace. This avoids leaving extra space though, so if you're at the first/last workspace it'll be aligned to the left/right edge. BUG=none TEST=none R=oshima@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107580

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
	M	ui/aura_shell/workspace/workspace.cc	View		3 chunks	+2 lines, -3 lines	0 comments	Download
	M	ui/aura_shell/workspace/workspace_manager.cc	View		2 chunks	+10 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

oshima

9 years, 1 month ago (2011-10-27 08:43:05 UTC) #2

LGTM

nice, i like it.

http://codereview.chromium.org/8399027/diff/1/ui/aura_shell/workspace/workspa...
File ui/aura_shell/workspace/workspace_manager.cc (right):

http://codereview.chromium.org/8399027/diff/1/ui/aura_shell/workspace/workspa...
ui/aura_shell/workspace/workspace_manager.cc:121:
transform.SetTranslateX(-viewport_->GetTargetBounds().x() + dx);
can you remove -viewport->GetTargetBounds().x().?  It should always  be 0 and
seems like I forgot to remove after playing with something.

Expand Messages | Collapse Messages