Fire canplaythrough event at the proper time for audio/video

media/base/pipeline_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implementation of Pipeline & PipelineStatusNotification (an async-to-sync
 // callback adapter).
 
 #ifndef MEDIA_BASE_PIPELINE_IMPL_H_
 #define MEDIA_BASE_PIPELINE_IMPL_H_
 
@@ skipping 243 matching lines @@
   // Carries out notifying filters that the preload value has changed.
   void PreloadChangedTask(Preload preload);
 
   // Carries out notifying filters that we are seeking to a new timestamp.
   void SeekTask(base::TimeDelta time, const PipelineStatusCB& seek_callback);
 
   // Carries out handling a notification from a filter that it has ended.
   void NotifyEndedTask();
 
   // Carries out handling a notification of network event.
-  void NotifyNetworkEventTask(bool is_downloading_data);
+  void NotifyNetworkEventTask(NetworkEvent type);
 
   // Carries out disabling the audio renderer.
   void DisableAudioRendererTask();
 
   // Carries out advancing to the next filter during Play()/Pause()/Seek().
   void FilterStateTransitionTask();
 
   // Carries out advancing to the next teardown operation.
   void TeardownStateTransitionTask();
 
@@ skipping 34 matching lines @@
   // state first.
   // 2. when pipeline has been initialized, we will first transit to pausing
   // => flushing => stopping => stopped state.
   // This will remove the race condition during stop between filters.
   void TearDownPipeline();
 
   // Compute the current time. Assumes that the lock has been acquired by the
   // caller.
   base::TimeDelta GetCurrentTime_Locked() const;
 
+  // Compute the buffered time. Assumes that the lock has been acquired by the
+  // caller.
+  base::TimeDelta GetBufferedTime_Locked();
+
   // Initiates a Stop() on |demuxer_| & |pipeline_filter_|. |callback|
   // is called once both objects have been stopped.
   void DoStop(const base::Closure& callback);
 
   // Called when |demuxer_| has stopped. This method calls Stop()
   // on |pipeline_filter_|.
   void OnDemuxerStopDone(const base::Closure& callback);
 
   // Initiates a Seek() on the |demuxer_| & |pipeline_filter_|.
   void DoSeek(base::TimeDelta seek_timestamp);
 
   // Called when |demuxer_| finishes seeking. If seeking was successful,
   // then Seek() is called on |pipeline_filter_|.
   void OnDemuxerSeekDone(base::TimeDelta seek_timestamp,
                          PipelineStatus status);
 
+  // If the media can be played through to the end without pausing for
+  // buffering, sends a notification saying such.
+  void NotifyCanPlayThroughIfNeeded();
+
+  // Returns an approximation of the download speed of the resource loader in

[acolwell GONE FROM CHROMIUM, 2011/10/28 18:24:13]

Remove "of the resource loader" since that is an implementation detail of how
the FFmpegDemuxer -> BufferedDataSource->BufferedResourceLoader stack works.
Technically the pipeline should not be aware of such things.

[vrk (LEFT CHROMIUM), 2011/11/01 21:57:34]

Done.

+  // bytes per second. Returns -1 if an approximation cannot be determined.
+  // Assumes that the lock has been acquired by the caller.
+  int ApproximateDownloadRate_Locked();

[acolwell GONE FROM CHROMIUM, 2011/10/28 18:24:13]

Might want to change this to ApproximateDownloadByteRate() so that the units are
clear at the call sites.

[vrk (LEFT CHROMIUM), 2011/11/01 21:57:34]

That's a good idea. Done.

+
+  // Returns true when the pipeline believes the media can be played through to
+  // the end without pausing for buffering; returns false otherwise.
+  // Assumes that the lock has been acquired by the caller.
+  bool ShouldNotifyCanPlayThrough_Locked();
+
   // Message loop used to execute pipeline tasks.
   MessageLoop* message_loop_;
 
   // MediaLog to which to log events.
   scoped_refptr<MediaLog> media_log_;
 
   // Lock used to serialize access for the following data members.
   mutable base::Lock lock_;
 
   // Whether or not the pipeline is running.
@@ skipping 122 matching lines @@
   scoped_refptr<Demuxer> demuxer_;
 
   // Helper class that stores filter references during pipeline
   // initialization.
   class PipelineInitState;
   scoped_ptr<PipelineInitState> pipeline_init_state_;
 
   // Statistics.
   PipelineStatistics statistics_;
 
+  // Number of bytes downloaded since download began. Is reset every time
+  // download continues from a previous defer. Used to approximate download
+  // speed.
+  unsigned long long starting_bytes_loaded_;

[acolwell GONE FROM CHROMIUM, 2011/10/28 18:24:13]

how about making this int64

[vrk (LEFT CHROMIUM), 2011/11/01 21:57:34]

Done.

+
+  // Time at which download began. Is reset every time download continues
+  // from a previous defer. Used to approximate download speed.
+  base::Time starting_time_;
+
+  // Indicates whether the pipeline has sent a notification to its client that
+  // the media can play through to the end.
+  bool has_notified_can_play_through_;
+
+  // True if the pipeline is actively downloading bytes, false otherwise.
+  bool is_downloading_data_;
+
+  // An approximation of the download speed in bytes per second. -1 means the
+  // download speed is unknown.
+  int last_approximate_download_rate_;
+
   FRIEND_TEST_ALL_PREFIXES(PipelineImplTest, GetBufferedTime);
 
   DISALLOW_COPY_AND_ASSIGN(PipelineImpl);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_PIPELINE_IMPL_H_