Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1636)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 8399022: Add a couple of notifications related settings to app/extensions sync: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.h
===================================================================
--- chrome/browser/extensions/extension_service.h (revision 107300)
+++ chrome/browser/extensions/extension_service.h (working copy)
@@ -211,6 +211,15 @@
virtual void SetIsIncognitoEnabled(const std::string& extension_id,
bool enabled);
+ virtual bool IsNotificationsInitialSetupDone(
asargent_no_longer_on_chrome 2011/10/27 16:52:21 Let's remove this IsNotificationsInitialSetupDone
Munjal (Google) 2011/10/27 18:35:05 Done. When I added this method, I thought it will
+ const std::string& extension_id) const;
+ virtual void SetNotificationsInitialSetupDone(const std::string& extension_id,
asargent_no_longer_on_chrome 2011/10/27 16:52:21 Rename suggestion: SetAppNotificationSetupDone
Munjal (Google) 2011/10/27 18:35:05 Done.
+ bool value);
+
+ virtual bool IsNotificationsDisabled(const std::string& extension_id) const;
asargent_no_longer_on_chrome 2011/10/27 16:52:21 Let's remove this IsNotificationsDisabled method i
Munjal (Google) 2011/10/27 18:35:05 Done.
+ virtual void SetNotificationsDisabled(const std::string& extension_id,
asargent_no_longer_on_chrome 2011/10/27 16:52:21 Rename suggestion: SetAppNotificationDisabled
Munjal (Google) 2011/10/27 18:35:05 Done.
+ bool value);
+
// Returns true if the given extension can see events and data from another
// sub-profile (incognito to original profile, or vice versa).
bool CanCrossIncognito(const Extension* extension);

Powered by Google App Engine
This is Rietveld 408576698