base::Bind usage

webkit/appcache/appcache_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/appcache/appcache_service.h"
 
+#include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/stl_util.h"
 #include "net/base/io_buffer.h"
 #include "webkit/appcache/appcache.h"
 #include "webkit/appcache/appcache_backend_impl.h"
 #include "webkit/appcache/appcache_entry.h"
 #include "webkit/appcache/appcache_histograms.h"
 #include "webkit/appcache/appcache_policy.h"
 #include "webkit/appcache/appcache_quota_client.h"
@@ skipping 26 matching lines @@
 
   virtual void Start() = 0;
   virtual void Cancel();
 
  protected:
   void CallCallback(int rv) {
     if (callback_) {
       // Defer to guarentee async completion.
       MessageLoop::current()->PostTask(
           FROM_HERE,
-          NewRunnableFunction(&DeferredCallCallback, callback_, rv));
+          base::Bind(&DeferredCallCallback, callback_, rv));

[James Hawkins, 2011/10/27 03:30:32]

Nit: Looks like we can save a line and put this parameter on the previous line.

[michaeln, 2011/10/27 19:20:02]

Done.

     }
     callback_ = NULL;
   }
 
   static void DeferredCallCallback(net::OldCompletionCallback* callback, int rv) {

[James Hawkins, 2011/10/27 03:30:32]

Nit: This was wrong from before, but this breaks 80 cols.

[michaeln, 2011/10/27 19:20:02]

Done.

     callback->Run(rv);
   }
 
   AppCacheService* service_;
   net::OldCompletionCallback* callback_;
 };
 
 void AppCacheService::AsyncHelper::Cancel() {
   if (callback_) {
     callback_->Run(net::ERR_ABORTED);
@@ skipping 420 matching lines @@
   backends_.insert(
       BackendMap::value_type(backend_impl->process_id(), backend_impl));
 }
 
 void AppCacheService::UnregisterBackend(
     AppCacheBackendImpl* backend_impl) {
   backends_.erase(backend_impl->process_id());
 }
 
 }  // namespace appcache