base::Bind usage

webkit/appcache/appcache_response.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/appcache/appcache_response.h"
 
+#include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/pickle.h"
 #include "base/string_util.h"
 #include "net/base/net_errors.h"
 #include "net/base/io_buffer.h"
 #include "webkit/appcache/appcache_service.h"
 
 namespace appcache {
 
@@ skipping 51 matching lines @@
     : http_info(info), response_data_size(kUnkownResponseDataSize) {}
 
 HttpResponseInfoIOBuffer::~HttpResponseInfoIOBuffer() {}
 
 // AppCacheResponseIO ----------------------------------------------
 
 AppCacheResponseIO::AppCacheResponseIO(
     int64 response_id, int64 group_id, AppCacheDiskCacheInterface* disk_cache)
     : response_id_(response_id), group_id_(group_id), disk_cache_(disk_cache),
       entry_(NULL), buffer_len_(0), user_callback_(NULL),
-      ALLOW_THIS_IN_INITIALIZER_LIST(method_factory_(this)),
+      ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)),
       ALLOW_THIS_IN_INITIALIZER_LIST(raw_callback_(
           new net::CancelableOldCompletionCallback<AppCacheResponseIO>(
               this, &AppCacheResponseIO::OnRawIOComplete))) {
 }
 
 AppCacheResponseIO::~AppCacheResponseIO() {
   raw_callback_->Cancel();
   if (entry_)
     entry_->Close();
 }
 
 void AppCacheResponseIO::ScheduleIOOldCompletionCallback(int result) {
   MessageLoop::current()->PostTask(FROM_HERE,

[James Hawkins, 2011/10/27 03:30:32]

nit: Parameters must start on the same column.  In general, I've been doing:

PostTask(
    FROM_HERE, blahblah,
    base::Bind(...));

[michaeln, 2011/10/27 19:20:02]

Done.

-      method_factory_.NewRunnableMethod(
-          &AppCacheResponseIO::OnIOComplete, result));
+      base::Bind(&AppCacheResponseIO::OnIOComplete,
+                 weak_factory_.GetWeakPtr(), result));
 }
 
 void AppCacheResponseIO::InvokeUserOldCompletionCallback(int result) {
   // Clear the user callback and buffers prior to invoking the callback
   // so the caller can schedule additional operations in the callback.
   buffer_ = NULL;
   info_buffer_ = NULL;
   net::OldCompletionCallback* temp_user_callback = user_callback_;
   user_callback_ = NULL;
   temp_user_callback->Run(result);
@@ skipping 283 matching lines @@
   }
 
   if (info_buffer_)
     ContinueWriteInfo();
   else
     ContinueWriteData();
 }
 
 }  // namespace appcache