chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm - Issue 8399017: Fix a crash in FullscreenExitBubbleController when the user clicks the "Exit full screen" button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm

Issue 8399017: Fix a crash in FullscreenExitBubbleController when the user clicks the "Exit full screen" button. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add test Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/browser_window_controller.mm ('K') | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm » ('j') | chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm b/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm

index bdbfcd2694d903c476e4916ee231e4a27fa2b34a..fade662d9be98b7286eb31f3b1e41e0c298f9937 100644

--- a/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm

@@ -93,7 +93,6 @@ const float kHideDuration = 0.7;

- (void)deny:(id)sender {

DCHECK(fullscreen_bubble::ShowButtonsForType(bubbleType_));

browser_->OnDenyFullscreenPermission(bubbleType_);

- [self hideSoon];

}

- (void)showButtons:(BOOL)show {