Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 8399009: Add support for touch based zoom gesture on Windows. This change also handles the WM_POINTERDOWN (Closed)

Created:
9 years, 1 month ago by ananta
Modified:
9 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Add support for touch based zoom gesture on Windows. This change also handles the WM_POINTERDOWN and WM_POINTERUP messages to scroll the page if we touch the scrollbar. BUG=none TEST=Touch based zoom should work on Windows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108232

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 8

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -49 lines) Patch
M content/browser/renderer_host/render_widget_host_view_win.h View 1 2 3 4 4 chunks +29 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 3 4 9 chunks +123 lines, -45 lines 0 comments Download
M content/common/view_messages.h View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 4 5 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 6 3 chunks +26 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ananta
9 years, 1 month ago (2011-10-26 22:09:47 UTC) #1
jschuh
lgtm with a minor nit http://codereview.chromium.org/8399009/diff/4002/content/browser/renderer_host/render_widget_host_view_win.h File content/browser/renderer_host/render_widget_host_view_win.h (right): http://codereview.chromium.org/8399009/diff/4002/content/browser/renderer_host/render_widget_host_view_win.h#newcode52 content/browser/renderer_host/render_widget_host_view_win.h:52: Would be good to ...
9 years, 1 month ago (2011-10-28 01:40:41 UTC) #2
cpu_(ooo_6.6-7.5)
http://codereview.chromium.org/8399009/diff/4002/content/browser/renderer_host/render_widget_host_view_win.cc File content/browser/renderer_host/render_widget_host_view_win.cc (right): http://codereview.chromium.org/8399009/diff/4002/content/browser/renderer_host/render_widget_host_view_win.cc#newcode231 content/browser/renderer_host/render_widget_host_view_win.cc:231: *zoom = distance < start ? zoom_out : zoom_in ...
9 years, 1 month ago (2011-10-28 02:30:03 UTC) #3
ananta
http://codereview.chromium.org/8399009/diff/4002/content/browser/renderer_host/render_widget_host_view_win.cc File content/browser/renderer_host/render_widget_host_view_win.cc (right): http://codereview.chromium.org/8399009/diff/4002/content/browser/renderer_host/render_widget_host_view_win.cc#newcode231 content/browser/renderer_host/render_widget_host_view_win.cc:231: On 2011/10/28 02:30:03, cpu wrote: > *zoom = distance ...
9 years, 1 month ago (2011-10-28 18:42:02 UTC) #4
ananta
http://codereview.chromium.org/8399009/diff/4002/content/browser/renderer_host/render_widget_host_view_win.h File content/browser/renderer_host/render_widget_host_view_win.h (right): http://codereview.chromium.org/8399009/diff/4002/content/browser/renderer_host/render_widget_host_view_win.h#newcode52 content/browser/renderer_host/render_widget_host_view_win.h:52: On 2011/10/28 01:40:41, Justin Schuh wrote: > Would be ...
9 years, 1 month ago (2011-10-28 18:43:10 UTC) #5
jam
rubber stamp lgtm
9 years, 1 month ago (2011-10-28 19:26:19 UTC) #6
cpu_(ooo_6.6-7.5)
lgtm
9 years, 1 month ago (2011-10-28 19:53:56 UTC) #7
ananta
On 2011/10/28 19:53:56, cpu wrote: > lgtm I found that the zoom factor stuff was ...
9 years, 1 month ago (2011-11-01 01:30:59 UTC) #8
James Cook
9 years, 1 month ago (2011-11-02 02:29:21 UTC) #9
On 2011/11/01 01:30:59, ananta wrote:
> On 2011/10/28 19:53:56, cpu wrote:
> > lgtm
> I found that the zoom factor stuff was flaky. Turned out that the zoom changed
> notification coming in from the renderer was always sending the level as 0.
> Refactored the zoomLevelChanged function into a helper function which is now
> called from both places.
> 
> PTAL.
> 
> Thanks
> Ananta

This change broke the linux touch build ("function" in render_view_impl.cc
should probably be "zoom").  I reverted it.

Powered by Google App Engine
This is Rietveld 408576698