Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 8399007: Removing dedicated worker-related IPC codei (first round). (Closed)

Created:
9 years, 1 month ago by Dmitry Lomov (no reviews)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Removing dedicated worker-related IPC codei (first round). Since dedicated workers moved in-process, IPC-related code for them is unused. This is the first round of clean-up Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107496

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 2

Patch Set 3 : Build fix in tests #

Patch Set 4 : CR feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -396 lines) Patch
M chrome/browser/debugger/devtools_sanity_unittest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/workers_ui.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/debugger/worker_devtools_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 7 chunks +10 lines, -34 lines 0 comments Download
M content/browser/worker_host/worker_service.cc View 4 chunks +63 lines, -95 lines 0 comments Download
M content/common/worker_messages.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/content_worker.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M content/worker/websharedworker_stub.h View 4 chunks +26 lines, -3 lines 0 comments Download
M content/worker/websharedworker_stub.cc View 1 2 3 4 chunks +29 lines, -2 lines 0 comments Download
D content/worker/webworker_stub.h View 1 chunk +0 lines, -47 lines 0 comments Download
D content/worker/webworker_stub.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D content/worker/webworker_stub_base.h View 1 chunk +0 lines, -48 lines 0 comments Download
D content/worker/webworker_stub_base.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M content/worker/webworkerclient_proxy.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/worker/webworkerclient_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/worker/worker_thread.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/worker/worker_thread.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M content/worker/worker_webapplicationcachehost_impl.h View 1 chunk +5 lines, -7 lines 0 comments Download
M content/worker/worker_webapplicationcachehost_impl.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dmitry Lomov (no reviews)
This removes much (but not all yet) of dedicated workers IPC-related implementation in chromium
9 years, 1 month ago (2011-10-26 22:10:32 UTC) #1
jam
lgtm http://codereview.chromium.org/8399007/diff/2001/content/browser/worker_host/worker_service.cc File content/browser/worker_host/worker_service.cc (right): http://codereview.chromium.org/8399007/diff/2001/content/browser/worker_host/worker_service.cc#newcode142 content/browser/worker_host/worker_service.cc:142: void WorkerService::CancelCreateDedicatedWorker( i guess this is second round? ...
9 years, 1 month ago (2011-10-26 22:25:37 UTC) #2
Dmitry Lomov (no reviews)
On 2011/10/26 22:25:37, John Abd-El-Malek wrote: > lgtm > > http://codereview.chromium.org/8399007/diff/2001/content/browser/worker_host/worker_service.cc > File content/browser/worker_host/worker_service.cc (right): ...
9 years, 1 month ago (2011-10-26 23:28:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dslomov@chromium.org/8399007/1023
9 years, 1 month ago (2011-10-26 23:44:34 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-10-27 00:43:58 UTC) #5
Change committed as 107496

Powered by Google App Engine
This is Rietveld 408576698