Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 8399006: chromeos: Fix UpdateScreenTest.NoUpdate and TestUpdateAvailable (Closed)

Created:
9 years, 1 month ago by satorux1
Modified:
9 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

chromeos: Fix UpdateScreenTest.NoUpdate and TestUpdateAvailable The tests were broken by crrev.com/107308 status() is not called in UpdateStatusChanged() in most cases as we now pass status instead of the update library, but it's still called when ExitUpdate() is called from UpdateStatusChanged(). TEST=out/Release/browser_tests --gtest_filter=UpdateScreenTest.* BUG=chromium-os:16564 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107493

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -27 lines) Patch
M chrome/browser/chromeos/login/update_screen_browsertest.cc View 1 4 chunks +8 lines, -27 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
satorux1
9 years, 1 month ago (2011-10-26 22:16:03 UTC) #1
stevenjb
9 years, 1 month ago (2011-10-26 23:04:10 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698