content/browser/download/download_file.h - Issue 8399001: Use a DownloadRequestHandle pointer in construction to allow mocking for tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_file.h

Issue 8399001: Use a DownloadRequestHandle pointer in construction to allow mocking for tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed compile error. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_manager_unittest.cc ('k') | content/browser/download/download_file.cc » ('j') | content/browser/download/download_item.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_file.h

diff --git a/content/browser/download/download_file.h b/content/browser/download/download_file.h

index 3424054cb82aa5ff36d0dd956b5da45b865bf534..fb2489fa23cccf64450d015443376bb217695ce0 100644

--- a/content/browser/download/download_file.h

+++ b/content/browser/download/download_file.h

@@ -25,8 +25,9 @@ class ResourceDispatcherHost;

// cancelled, the DownloadFile is destroyed.

class CONTENT_EXPORT DownloadFile : public BaseFile {

public:

+ // Takes ownership of the object pointed to by |request_handle|.

DownloadFile(const DownloadCreateInfo* info,

- const DownloadRequestHandle& request_handle,

+ DownloadRequestHandleInterface* request_handle,

DownloadManager* download_manager);

virtual ~DownloadFile();

@@ -65,7 +66,7 @@ class CONTENT_EXPORT DownloadFile : public BaseFile {

// The handle to the request information. Used for operations outside the

// download system, specifically canceling a download.

- DownloadRequestHandle request_handle_;

+ scoped_ptr<DownloadRequestHandleInterface> request_handle_;

// DownloadManager this download belongs to.

scoped_refptr<DownloadManager> download_manager_;