Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Unified Diff: content/browser/download/download_file.cc

Issue 8399001: Use a DownloadRequestHandle pointer in construction to allow mocking for tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to TOT. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/download_file.h ('k') | content/browser/download/download_file_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_file.cc
diff --git a/content/browser/download/download_file.cc b/content/browser/download/download_file.cc
index 06f643ef08f085a9fe45ec568cff6f1bedcd5920..a1980f4b426199b4f36a340add3bdab4c380c54c 100644
--- a/content/browser/download/download_file.cc
+++ b/content/browser/download/download_file.cc
@@ -24,7 +24,7 @@ static const int kMaxUniqueFiles = 100;
}
DownloadFile::DownloadFile(const DownloadCreateInfo* info,
- const DownloadRequestHandle& request_handle,
+ DownloadRequestHandleInterface* request_handle,
DownloadManager* download_manager)
: BaseFile(info->save_info.file_path,
info->url(),
@@ -43,7 +43,7 @@ DownloadFile::~DownloadFile() {
void DownloadFile::CancelDownloadRequest() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
- request_handle_.CancelRequest();
+ request_handle_->CancelRequest();
}
DownloadManager* DownloadFile::GetDownloadManager() {
@@ -58,7 +58,7 @@ std::string DownloadFile::DebugString() const {
" Base File = %s"
" }",
id_.local(),
- request_handle_.DebugString().c_str(),
+ request_handle_->DebugString().c_str(),
BaseFile::DebugString().c_str());
}
« no previous file with comments | « content/browser/download/download_file.h ('k') | content/browser/download/download_file_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698