Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Side by Side Diff: content/browser/download/download_file.h

Issue 8399001: Use a DownloadRequestHandle pointer in construction to allow mocking for tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to TOT. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_H_ 5 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_H_
6 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_H_ 6 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/basictypes.h" 11 #include "base/basictypes.h"
12 #include "base/memory/ref_counted.h" 12 #include "base/memory/ref_counted.h"
13 #include "content/browser/download/base_file.h" 13 #include "content/browser/download/base_file.h"
14 #include "content/browser/download/download_id.h" 14 #include "content/browser/download/download_id.h"
15 #include "content/browser/download/download_request_handle.h" 15 #include "content/browser/download/download_request_handle.h"
16 #include "content/browser/download/download_types.h" 16 #include "content/browser/download/download_types.h"
17 #include "content/common/content_export.h" 17 #include "content/common/content_export.h"
18 18
19 struct DownloadCreateInfo; 19 struct DownloadCreateInfo;
20 class DownloadManager; 20 class DownloadManager;
21 class ResourceDispatcherHost; 21 class ResourceDispatcherHost;
22 22
23 // These objects live exclusively on the download thread and handle the writing 23 // These objects live exclusively on the download thread and handle the writing
24 // operations for one download. These objects live only for the duration that 24 // operations for one download. These objects live only for the duration that
25 // the download is 'in progress': once the download has been completed or 25 // the download is 'in progress': once the download has been completed or
26 // cancelled, the DownloadFile is destroyed. 26 // cancelled, the DownloadFile is destroyed.
27 class CONTENT_EXPORT DownloadFile : public BaseFile { 27 class CONTENT_EXPORT DownloadFile : public BaseFile {
28 public: 28 public:
29 // Takes ownership of the object pointed to by |request_handle|.
29 DownloadFile(const DownloadCreateInfo* info, 30 DownloadFile(const DownloadCreateInfo* info,
30 const DownloadRequestHandle& request_handle, 31 DownloadRequestHandleInterface* request_handle,
31 DownloadManager* download_manager); 32 DownloadManager* download_manager);
32 virtual ~DownloadFile(); 33 virtual ~DownloadFile();
33 34
34 // Cancels the download request associated with this file. 35 // Cancels the download request associated with this file.
35 void CancelDownloadRequest(); 36 void CancelDownloadRequest();
36 37
37 int id() const { return id_.local(); } 38 int id() const { return id_.local(); }
38 DownloadManager* GetDownloadManager(); 39 DownloadManager* GetDownloadManager();
39 const DownloadId& global_id() const { return id_; } 40 const DownloadId& global_id() const { return id_; }
40 41
(...skipping 19 matching lines...) Expand all
60 const FilePath& path, 61 const FilePath& path,
61 const FilePath::StringType& suffix); 62 const FilePath::StringType& suffix);
62 63
63 private: 64 private:
64 // The unique identifier for this download, assigned at creation by 65 // The unique identifier for this download, assigned at creation by
65 // the DownloadFileManager for its internal record keeping. 66 // the DownloadFileManager for its internal record keeping.
66 DownloadId id_; 67 DownloadId id_;
67 68
68 // The handle to the request information. Used for operations outside the 69 // The handle to the request information. Used for operations outside the
69 // download system, specifically canceling a download. 70 // download system, specifically canceling a download.
70 DownloadRequestHandle request_handle_; 71 scoped_ptr<DownloadRequestHandleInterface> request_handle_;
71 72
72 // DownloadManager this download belongs to. 73 // DownloadManager this download belongs to.
73 scoped_refptr<DownloadManager> download_manager_; 74 scoped_refptr<DownloadManager> download_manager_;
74 75
75 DISALLOW_COPY_AND_ASSIGN(DownloadFile); 76 DISALLOW_COPY_AND_ASSIGN(DownloadFile);
76 }; 77 };
77 78
78 #endif // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_H_ 79 #endif // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_H_
OLDNEW
« no previous file with comments | « chrome/browser/download/download_manager_unittest.cc ('k') | content/browser/download/download_file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698