Open NaCl IRT file only once at startup

chrome/nacl/nacl_listener.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/nacl/nacl_listener.h"
 
 #include <errno.h>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 78 matching lines @@
 
 bool NaClListener::OnMessageReceived(const IPC::Message& msg) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(NaClListener, msg)
       IPC_MESSAGE_HANDLER(NaClProcessMsg_Start, OnStartSelLdr)
       IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
-void NaClListener::OnStartSelLdr(
-    std::vector<nacl::FileDescriptor> handles,
-    bool have_irt_file) {
+void NaClListener::OnStartSelLdr(std::vector<nacl::FileDescriptor> handles) {
 #if defined(OS_LINUX)
   nacl::SetCreateMemoryObjectFunc(content::MakeSharedMemorySegmentViaIPC);
 #elif defined(OS_MACOSX)
   nacl::SetCreateMemoryObjectFunc(CreateMemoryObject);
   CHECK(handles.size() >= 1);
   g_shm_fd = nacl::ToNativeHandle(handles[handles.size() - 1]);
   handles.pop_back();
 #endif
 
-  if (have_irt_file) {
-    CHECK(handles.size() >= 1);
-    NaClHandle irt_handle = nacl::ToNativeHandle(handles[handles.size() - 1]);
-    handles.pop_back();
+  CHECK(handles.size() >= 1);
+  NaClHandle irt_handle = nacl::ToNativeHandle(handles[handles.size() - 1]);
+  handles.pop_back();
+
 #if defined(OS_WIN)
-    int irt_desc = _open_osfhandle(reinterpret_cast<intptr_t>(irt_handle),
-                                   _O_RDWR | _O_BINARY);
-    if (irt_desc < 0) {
-      LOG(ERROR) << "_open_osfhandle() failed";
-      return;
-    }
+  int irt_desc = _open_osfhandle(reinterpret_cast<intptr_t>(irt_handle),
+                                 _O_RDONLY | _O_BINARY);
+  if (irt_desc < 0) {
+    LOG(ERROR) << "_open_osfhandle() failed";
+    return;
+  }
 #else
-    int irt_desc = irt_handle;
+  int irt_desc = irt_handle;
 #endif
-    NaClSetIrtFileDesc(irt_desc);
-  }
+
+  NaClSetIrtFileDesc(irt_desc);
 
   scoped_array<NaClHandle> array(new NaClHandle[handles.size()]);
   for (size_t i = 0; i < handles.size(); i++) {
     array[i] = nacl::ToNativeHandle(handles[i]);
   }
   NaClMainForChromium(static_cast<int>(handles.size()), array.get(),
                       debug_enabled_);
   NOTREACHED();
 }