Allow building without notification support.

Allow building without notification support.

BUG=None
TEST=Existing


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107708

[Satish, 2011-10-26 15:44:42]

Could you issue a try run to verify the new flags work fine with ToT chrome?

[John Knottenbelt, 2011-10-26 16:57:17]

Definitely. I  have two try jobs in progress, one with the feature enabled and
one with it disabled.

This recent patch disables the extension/notification browser tests which time
out with the feature disabled.

[jam, 2011-10-26 21:50:03]

lgtm

[Satish, 2011-10-27 13:28:23]

lgtm

[John Knottenbelt, 2011-10-27 15:40:33]

Thanks for the review.

For some reason, the try bots aren't posting their results here, but for the
enabled case we have:

Mac (passed), Linux (passed), Windows (failed, but unrelated failure)
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/56623
http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/56856
http://build.chromium.org/p/tryserver.chromium/builders/win/builds/63442

For the disabled case, I accidentally submitted patch set 2 to the try bots
again, so it failed again on the interactive ui tests for windows. Windows seems
to be the only platform where the try bots run the interactive_ui_tests. I have
submitted a new try job and will post the results when they become available.


On 2011/10/27 13:28:23, Satish wrote:
> lgtm

[John Knottenbelt, 2011-10-28 08:52:53]

Here are the try bot results with notifications disabled:
Mac (passed), Linux (passed), Windows (failed, but unrelated failure)
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/56645
http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/56878
http://build.chromium.org/p/tryserver.chromium/builders/win/builds/63469

On 2011/10/27 15:40:33, John Knottenbelt wrote:
> Thanks for the review.
> 
> For some reason, the try bots aren't posting their results here, but for the
> enabled case we have:
> 
> Mac (passed), Linux (passed), Windows (failed, but unrelated failure)
> http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/56623
> http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/56856
> http://build.chromium.org/p/tryserver.chromium/builders/win/builds/63442
> 
> For the disabled case, I accidentally submitted patch set 2 to the try bots
> again, so it failed again on the interactive ui tests for windows. Windows
seems
> to be the only platform where the try bots run the interactive_ui_tests. I
have
> submitted a new try job and will post the results when they become available.
> 
> 
> On 2011/10/27 13:28:23, Satish wrote:
> > lgtm

[commit-bot: I haz the power, 2011-10-28 09:23:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jknotten@chromium.org/8396043/9001

[commit-bot: I haz the power, 2011-10-28 10:41:58]

Change committed as 107708