Issue 8396040: Use StrictModeFlag in preparser and preparse data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8396040: Use StrictModeFlag in preparser and preparse data. (Closed)

Created:
9 years, 1 month ago by Steven

Modified:
9 years, 1 month ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Use StrictModeFlag in preparser and preparse data. Committed: http://code.google.com/p/v8/source/detail?r=9818

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -32 lines)			Patch
M	src/globals.h	View	1 chunk	+14 lines, -0 lines	1 comment	Download
M	src/parser.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/parser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/preparse-data.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/preparser.h	View	5 chunks	+9 lines, -17 lines	0 comments	Download
M	src/preparser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/v8globals.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

9 years, 1 month ago (2011-10-27 07:27:46 UTC) #2

lgtm

http://codereview.chromium.org/8396040/diff/1/src/globals.h
File src/globals.h (right):

http://codereview.chromium.org/8396040/diff/1/src/globals.h#newcode371
src/globals.h:371: kInvalidStrictFlag
If possible, get rid of kInvalidStrictFlag.
If the problem is the assert, it's because we cast some integer to
StrictModeFlag, and then we should really test the value *before* casting it
(which is what we mean, and it's also not undefined behavior). If a value
already has the enum type, we shouldn't need to test.

Expand Messages | Collapse Messages