Issue 8395053: Adding flag for turning on the Media Source API

Issue 8395053: Adding flag for turning on the Media Source API (Closed)

Created:
9 years, 1 month ago by acolwell GONE FROM CHROMIUM

Modified:
9 years, 1 month ago

Reviewers:
jam, scherkus (not reviewing)

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, jam, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Adding flag for turning on the Media Source API BUG=86536 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107632

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix nits #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -13 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/browser_render_process_host.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/content_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/content_switches.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/webmediaplayer_impl.h	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	webkit/glue/webmediaplayer_impl.cc	View	1	4 chunks	+14 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

LGTM w/ nits http://codereview.chromium.org/8395053/diff/1/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): http://codereview.chromium.org/8395053/diff/1/content/public/common/content_switches.cc#newcode202 content/public/common/content_switches.cc:202: // Enables MediaSource API on <audio>/<video> ...

9 years, 1 month ago (2011-10-26 18:15:31 UTC) #2

acolwell GONE FROM CHROMIUM

http://codereview.chromium.org/8395053/diff/1/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): http://codereview.chromium.org/8395053/diff/1/content/public/common/content_switches.cc#newcode202 content/public/common/content_switches.cc:202: // Enables MediaSource API on <audio>/<video> tags. On 2011/10/26 ...

9 years, 1 month ago (2011-10-26 18:30:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/8395053/19

9 years, 1 month ago (2011-10-27 18:52:24 UTC) #5

Change committed as 107632

Expand Messages | Collapse Messages