Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2075)

Unified Diff: chrome/browser/policy/configuration_policy_handler.cc

Issue 8395044: Disable the Developer Tools when Javascript is disabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/configuration_policy_handler.cc
diff --git a/chrome/browser/policy/configuration_policy_handler.cc b/chrome/browser/policy/configuration_policy_handler.cc
index 3122c288cbc80dff62cdd2d56fd69cc9caa5f4d6..755f273f832f8fc7c8dba2ac50bef936e3d8d650 100644
--- a/chrome/browser/policy/configuration_policy_handler.cc
+++ b/chrome/browser/policy/configuration_policy_handler.cc
@@ -1244,53 +1244,44 @@ bool JavascriptPolicyHandler::CheckPolicySettings(const PolicyMap& policies,
errors->AddError(kPolicyJavascriptEnabled,
IDS_POLICY_TYPE_ERROR,
ValueTypeToString(Value::TYPE_BOOLEAN));
- javascript_enabled = NULL;
}
if (default_setting && !default_setting->IsType(Value::TYPE_INTEGER)) {
errors->AddError(kPolicyDefaultJavaScriptSetting,
IDS_POLICY_TYPE_ERROR,
ValueTypeToString(Value::TYPE_INTEGER));
- default_setting = NULL;
}
- bool enabled;
- int setting;
- if (javascript_enabled &&
- default_setting &&
- javascript_enabled->GetAsBoolean(&enabled) &&
- default_setting->GetAsInteger(&setting) &&
- !enabled &&
- setting != CONTENT_SETTING_BLOCK) {
- errors->AddError(kPolicyDefaultJavaScriptSetting,
+ if (javascript_enabled && default_setting) {
+ errors->AddError(kPolicyJavascriptEnabled,
IDS_POLICY_OVERRIDDEN,
- GetPolicyName(kPolicyJavascriptEnabled));
+ GetPolicyName(kPolicyDefaultJavaScriptSetting));
}
+
return true;
}
void JavascriptPolicyHandler::ApplyPolicySettings(const PolicyMap& policies,
PrefValueMap* prefs) {
- const Value* javascript_enabled = policies.Get(kPolicyJavascriptEnabled);
+ int setting = CONTENT_SETTING_DEFAULT;
const Value* default_setting = policies.Get(kPolicyDefaultJavaScriptSetting);
- int setting = CONTENT_SETTING_DEFAULT;
- if (default_setting)
+ if (default_setting) {
default_setting->GetAsInteger(&setting);
-
- bool enabled = true;
- if (javascript_enabled && javascript_enabled->GetAsBoolean(&enabled)) {
- prefs->SetValue(prefs::kWebKitJavascriptEnabled,
- javascript_enabled->DeepCopy());
- // Force the javascript content setting to BLOCK when this policy disables
- // javascript globally.
- if (!enabled)
+ } else {
+ const Value* javascript_enabled = policies.Get(kPolicyJavascriptEnabled);
+ bool enabled = true;
+ if (javascript_enabled &&
+ javascript_enabled->GetAsBoolean(&enabled) &&
+ !enabled) {
setting = CONTENT_SETTING_BLOCK;
+ }
}
- if (setting != CONTENT_SETTING_DEFAULT)
+ if (setting != CONTENT_SETTING_DEFAULT) {
prefs->SetValue(prefs::kManagedDefaultJavaScriptSetting,
Value::CreateIntegerValue(setting));
+ }
}

Powered by Google App Engine
This is Rietveld 408576698