Disable the Developer Tools when Javascript is disabled.

chrome/test/functional/policy.py

 #!/usr/bin/python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import logging
+
 import pyauto_functional  # must come before pyauto.
 import pyauto
+from pyauto_errors import JSONInterfaceError
 
 
 class PolicyTest(pyauto.PyUITest):
   """Tests that the effects of policies are being enforced as expected."""
 
   def IsBlocked(self, url):
     """Returns true if navigating to |url| is blocked."""
     self.NavigateToURL(url)
     blocked = self.GetActiveTabTitle() == url + ' is not available'
     ret = self.ExecuteJavascript("""
         var hasError = false;
         var error = document.getElementById('errorDetails');
         if (error) {
           hasError = error.textContent.indexOf('Error 138') == 0;
         }
         domAutomationController.send(hasError.toString());
     """)
     ret = ret == 'true'
     self.assertEqual(blocked, ret)
     return blocked
 
-  def GetInnerHeight(self):
-    """Returns the inner height of the content area."""
-    ret = self.ExecuteJavascript(
-        'domAutomationController.send(innerHeight.toString());');
-    return int(ret)
+  def IsJavascriptEnabled(self):
+    try:
+      ret = self.ExecuteJavascript('domAutomationController.send("done");')
+      return ret == 'done'
+    except JSONInterfaceError as e:
+      if 'Javascript execution was blocked' == str(e):
+        logging.debug('The previous failure was expected')
+        return False
+      else:
+        raise e
 
   def testBlacklistPolicy(self):
     """Tests the URLBlacklist and URLWhitelist policies."""
     # This is an end to end test and not an exaustive test of the filter format.
     policy = {
       'URLBlacklist': [
         'news.google.com',
         'chromium.org',
       ],
       'URLWhitelist': [
@@ skipping 42 matching lines @@
 
     self.assertTrue(self.WaitForBookmarkBarVisibilityChange(False))
     self.assertFalse(self.GetBookmarkBarVisibility())
     self.ApplyAccelerator(pyauto.IDC_SHOW_BOOKMARK_BAR)
     self.assertTrue(self.WaitForBookmarkBarVisibilityChange(False))
     self.assertFalse(self.GetBookmarkBarVisibility())
     # When disabled by policy, it should never be displayed at all,
     # not even on the NTP.
     self.assertFalse(self.IsBookmarkBarDetached())
 
+  def testJavascriptPolicies(self):
+    """Tests the Javascript policies."""
+    # The navigation to about:blank after each policy reset is to reset the
+    # content settings state.
+    policy = {}
+    self.SetPolicies(policy)
+    self.assertTrue(self.IsJavascriptEnabled())
+    self.assertTrue(self.IsMenuCommandEnabled(pyauto.IDC_DEV_TOOLS))
+    self.assertTrue(self.IsMenuCommandEnabled(pyauto.IDC_DEV_TOOLS_CONSOLE))
+
+    policy['DeveloperToolsDisabled'] = True
+    self.SetPolicies(policy)
+    self.assertTrue(self.IsJavascriptEnabled())
+    self.assertFalse(self.IsMenuCommandEnabled(pyauto.IDC_DEV_TOOLS))
+    self.assertFalse(self.IsMenuCommandEnabled(pyauto.IDC_DEV_TOOLS_CONSOLE))
+
+    policy['DeveloperToolsDisabled'] = False
+    self.SetPolicies(policy)
+    self.assertTrue(self.IsJavascriptEnabled())
+    self.assertTrue(self.IsMenuCommandEnabled(pyauto.IDC_DEV_TOOLS))
+    self.assertTrue(self.IsMenuCommandEnabled(pyauto.IDC_DEV_TOOLS_CONSOLE))
+
+    # The Developer Tools still work when javascript is disabled.
+    policy['JavascriptEnabled'] = False
+    self.SetPolicies(policy)
+    self.assertFalse(self.IsJavascriptEnabled())
+    self.assertTrue(self.IsMenuCommandEnabled(pyauto.IDC_DEV_TOOLS))
+    self.assertTrue(self.IsMenuCommandEnabled(pyauto.IDC_DEV_TOOLS_CONSOLE))
+
+    # The Developer Tools can be explicitly disabled.
+    policy['DeveloperToolsDisabled'] = True
+    self.SetPolicies(policy)
+    self.NavigateToURL('about:blank')
+    self.assertFalse(self.IsJavascriptEnabled())
+    self.assertFalse(self.IsMenuCommandEnabled(pyauto.IDC_DEV_TOOLS))
+    self.assertFalse(self.IsMenuCommandEnabled(pyauto.IDC_DEV_TOOLS_CONSOLE))
+
+    # Javascript can also be disabled with content settings policies.
+    policy = {
+      'DefaultJavaScriptSetting': 2,
+    }
+    self.SetPolicies(policy)
+    self.NavigateToURL('about:blank')
+    self.assertFalse(self.IsJavascriptEnabled())
+    self.assertTrue(self.IsMenuCommandEnabled(pyauto.IDC_DEV_TOOLS))
+    self.assertTrue(self.IsMenuCommandEnabled(pyauto.IDC_DEV_TOOLS_CONSOLE))
+
+    # JavascriptEnabled = False also overrides the content setting.
+    policy = {
+      'DefaultJavaScriptSetting': 1,
+      'JavascriptEnabled': False,
+    }
+    self.SetPolicies(policy)
+    self.NavigateToURL('about:blank')
+    self.assertFalse(self.IsJavascriptEnabled())
+
+    # Javascript is always enabled for internal Chrome pages.
+    self.NavigateToURL('chrome://settings')
+    self.assertTrue(self.IsJavascriptEnabled())
+
 
 if __name__ == '__main__':
   pyauto_functional.Main()