chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc - Issue 8395042: [cros,de-hack] Get rid of singleton for the WebUILoginScreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc

Issue 8395042: [cros,de-hack] Get rid of singleton for the WebUILoginScreen. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: clang fix Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc

index 65fdd7d12660abccf4eddff7f89c8db701cf023b..2d6a1684f1b8722bd49e54977374fbde01eef950 100644

--- a/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc

+++ b/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc

@@ -136,8 +136,7 @@ void EulaScreenHandler::HandleOnExit(const base::ListValue* args) {

void EulaScreenHandler::HandleOnLearnMore(const base::ListValue* args) {

if (!help_app_.get()) {

- views::Widget* login_window = WebUILoginDisplay::GetLoginWindow();

- help_app_ = new HelpAppLauncher(login_window->GetNativeWindow());

+ help_app_ = new HelpAppLauncher(GetNativeWindow());

}

help_app_->ShowHelpTopic(HelpAppLauncher::HELP_STATS_USAGE);

}