chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc - Issue 8395042: [cros,de-hack] Get rid of singleton for the WebUILoginScreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc

Issue 8395042: [cros,de-hack] Get rid of singleton for the WebUILoginScreen. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: comment nit Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc b/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc

index afa00c2c1258a7a31366039bcfc5bd5b5d035b88..7fc122d6c5c3f1fd72aa524383e4579f287a71a8 100644

--- a/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc

+++ b/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc

@@ -71,8 +71,7 @@ void NetworkDropdownHandler::HandleNetworkDropdownShow(

if (!args->GetString(0, &element_id))

NOTREACHED();

- dropdown_.reset(new NetworkDropdown(

- web_ui_, WebUILoginDisplay::GetLoginWindow()->GetNativeWindow()));

+ dropdown_.reset(new NetworkDropdown(web_ui_, GetNativeWindow()));

}

void NetworkDropdownHandler::HandleNetworkDropdownHide(