chrome/browser/chromeos/login/login_display_host.h - Issue 8395042: [cros,de-hack] Get rid of singleton for the WebUILoginScreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/login_display_host.h

Issue 8395042: [cros,de-hack] Get rid of singleton for the WebUILoginScreen. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: comment nit Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/login_display_host.h

diff --git a/chrome/browser/chromeos/login/login_display_host.h b/chrome/browser/chromeos/login/login_display_host.h

index a1d051ac9cae9bf7f8bb85c31d2cc0758b3e82fa..b92b772372c194895aaa29c7d5b281fdc297d3ef 100644

--- a/chrome/browser/chromeos/login/login_display_host.h

+++ b/chrome/browser/chromeos/login/login_display_host.h

@@ -24,8 +24,9 @@ class LoginDisplayHost {

virtual ~LoginDisplayHost() {}

// Creates UI implementation specific login display instance (views/WebUI).

+ // The caller takes ownership of the returned value.

virtual LoginDisplay* CreateLoginDisplay(

- LoginDisplay::Delegate* delegate) const = 0;

+ LoginDisplay::Delegate* delegate) = 0;

// Returns corresponding native window.

// TODO(nkostylev): Might be refactored, move to views-specific code.