Make test URLFetcher implementations not derive from the URLFetcher implementation, since we want...

content/public/common/url_fetcher.h

Index: content/public/common/url_fetcher.h
===================================================================
--- content/public/common/url_fetcher.h	(revision 107268)
+++ content/public/common/url_fetcher.h	(working copy)
@@ -10,6 +10,7 @@
 #include <vector>
 
 #include "base/platform_file.h"
+#include "base/memory/ref_counted.h"

[wtc, 2011/10/26 23:34:46]

Nit: list this header before "base/platform_file.h".

[jam, 2011/10/26 23:39:06]

Done.

 #include "content/common/content_export.h"
 
 class FilePath;
@@ -82,9 +83,9 @@
                             RequestType request_type,
                             URLFetcherDelegate* d);
 
-  // Like above, but if there's a Factory registered with the implementation it
-  // will be used. |id| may be used during testing to identify who is creating
-  // the URLFetcher.
+  // Like above, but if there's a URLFetcherFactory registered with the
+  // implementation it will be used. |id| may be used during testing to identify
+  // who is creating the URLFetcher.
   static URLFetcher* Create(int id,
                             const GURL& url,
                             RequestType request_type,
@@ -158,9 +159,6 @@
   // when a 5xx response was received.
   virtual base::TimeDelta GetBackoffDelay() const = 0;
 
-  // Sets the back-off delay, allowing to mock 5xx requests in unit-tests.
-  virtual void SetBackoffDelayForTesting(base::TimeDelta backoff_delay) = 0;

[wtc, 2011/10/26 23:34:46]

This change should be mentioned in the CL's commit message.
(I found that this method now becomes TestURLFetcher::set_backoff_delay.)

[jam, 2011/10/26 23:39:06]

I had just added this method to the interface in my last cl, and now I moved it
back to set_backoff_delay now that tests don't derive from URLFetcher, so I
didn't think it was worth calling out

-
   // By default, the response is saved in a string. Call this method to save the
   // response to a temporary file instead. Must be called before Start().
   // |file_message_loop_proxy| will be used for all file operations.