chrome/service/cloud_print/cloud_print_url_fetcher.h - Issue 8395038: Make test URLFetcher implementations not derive from the URLFetcher implementation, since we want...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/cloud_print_url_fetcher.h

Issue 8395038: Make test URLFetcher implementations not derive from the URLFetcher implementation, since we want... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: move factory to its own file and remove Create function from URLFetcher impl Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/net/gaia/gaia_oauth_client_unittest.cc ('k') | chrome/service/cloud_print/cloud_print_url_fetcher.cc » ('j') | content/common/net/url_fetcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/service/cloud_print/cloud_print_url_fetcher.h

===================================================================

--- chrome/service/cloud_print/cloud_print_url_fetcher.h (revision 107268)

+++ chrome/service/cloud_print/cloud_print_url_fetcher.h (working copy)

@@ -107,7 +107,7 @@

private:

void StartRequestHelper(const GURL& url,

- URLFetcher::RequestType request_type,

+ content::URLFetcher::RequestType request_type,

Delegate* delegate,

int max_retries,

const std::string& post_data_mime_type,

@@ -118,7 +118,7 @@

scoped_ptr<content::URLFetcher> request_;

Delegate* delegate_;

int num_retries_;

- URLFetcher::RequestType request_type_;

+ content::URLFetcher::RequestType request_type_;

std::string additional_headers_;

std::string post_data_mime_type_;

std::string post_data_;