chrome/browser/policy/testing_policy_url_fetcher_factory.h - Issue 8395038: Make test URLFetcher implementations not derive from the URLFetcher implementation, since we want...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/testing_policy_url_fetcher_factory.h

Issue 8395038: Make test URLFetcher implementations not derive from the URLFetcher implementation, since we want... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: move factory to its own file and remove Create function from URLFetcher impl Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/mock_url_fetchers.cc ('k') | chrome/browser/policy/testing_policy_url_fetcher_factory.cc » ('j') | content/common/net/url_fetcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/testing_policy_url_fetcher_factory.h

===================================================================

--- chrome/browser/policy/testing_policy_url_fetcher_factory.h (revision 107268)

+++ chrome/browser/policy/testing_policy_url_fetcher_factory.h (working copy)

@@ -29,16 +29,16 @@

// Creates mock URLFetchers whose behavior can be controlled in tests. To do so

// set mock expectations on the method |Intercept|.

-class TestingPolicyURLFetcherFactory : public URLFetcher::Factory,

+class TestingPolicyURLFetcherFactory : public content::URLFetcherFactory,

public ScopedURLFetcherFactory {

public:

explicit TestingPolicyURLFetcherFactory(EventLogger* logger);

virtual ~TestingPolicyURLFetcherFactory();

- virtual URLFetcher* CreateURLFetcher(

+ virtual content::URLFetcher* CreateURLFetcher(

int id,

const GURL& url,

- URLFetcher::RequestType request_type,

+ content::URLFetcher::RequestType request_type,

content::URLFetcherDelegate* delegate) OVERRIDE;

LoggingWorkScheduler* scheduler();