chrome/browser/autofill/autofill_download_unittest.cc - Issue 8395038: Make test URLFetcher implementations not derive from the URLFetcher implementation, since we want...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_download_unittest.cc

Issue 8395038: Make test URLFetcher implementations not derive from the URLFetcher implementation, since we want... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: move factory to its own file and remove Create function from URLFetcher impl Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/autofill/autofill_download_unittest.cc

===================================================================

--- chrome/browser/autofill/autofill_download_unittest.cc (revision 107268)

+++ chrome/browser/autofill/autofill_download_unittest.cc (working copy)

@@ -312,7 +312,7 @@

mock_metric_logger));

fetcher = factory.GetFetcherByID(3);

ASSERT_TRUE(fetcher);

- fetcher->SetBackoffDelayForTesting(

+ fetcher->set_backoff_delay(

base::TimeDelta::FromMilliseconds(TestTimeouts::action_max_timeout_ms()));

FakeOnURLFetchComplete(fetcher, 500, std::string(responses[0]));

@@ -338,7 +338,7 @@

*(form_structures[0]), true, FieldTypeSet()));

fetcher = factory.GetFetcherByID(4);

ASSERT_TRUE(fetcher);

- fetcher->SetBackoffDelayForTesting(

+ fetcher->set_backoff_delay(

base::TimeDelta::FromMilliseconds(TestTimeouts::action_max_timeout_ms()));

FakeOnURLFetchComplete(fetcher, 503, std::string(responses[2]));

EXPECT_EQ(AutofillDownloadTest::REQUEST_UPLOAD_FAILED,

« no previous file with comments | « no previous file | chrome/browser/chromeos/login/mock_url_fetchers.h » ('j') | content/common/net/url_fetcher.cc » ('J')