Issue 8395031: Use the new ChromeV8ContextSet in ExtensionProcessBindings::StartRequestCommon()

Issue 8395031: Use the new ChromeV8ContextSet in ExtensionProcessBindings::StartRequestCommon() (Closed)

Created:
9 years, 2 months ago by Tessa MacDuff

Modified:
9 years, 1 month ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Use the new ChromeV8ContextSet in ExtensionProcessBindings::StartRequestCommon() BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107849

Patch Set 2 : improve naming #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
	M	chrome/renderer/extensions/extension_process_bindings.cc	View	1	3 chunks	+12 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Tessa MacDuff

Figured I might as well send this as a separate CL. (Yay git!)

9 years, 2 months ago (2011-10-26 01:22:03 UTC) #1

Aaron Boodman

lgtm w/ nits http://codereview.chromium.org/8395031/diff/1/chrome/renderer/extensions/extension_process_bindings.cc File chrome/renderer/extensions/extension_process_bindings.cc (right): http://codereview.chromium.org/8395031/diff/1/chrome/renderer/extensions/extension_process_bindings.cc#newcode459 chrome/renderer/extensions/extension_process_bindings.cc:459: // TODO: add this to ChromeV8Context. ...

9 years, 1 month ago (2011-10-28 23:29:46 UTC) #2

Tessa MacDuff

http://codereview.chromium.org/8395031/diff/1/chrome/renderer/extensions/extension_process_bindings.cc File chrome/renderer/extensions/extension_process_bindings.cc (right): http://codereview.chromium.org/8395031/diff/1/chrome/renderer/extensions/extension_process_bindings.cc#newcode459 chrome/renderer/extensions/extension_process_bindings.cc:459: // TODO: add this to ChromeV8Context. On 2011/10/28 23:29:46, ...

9 years, 1 month ago (2011-10-29 00:06:54 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tessamac@chromium.org/8395031/3002

9 years, 1 month ago (2011-10-29 00:07:19 UTC) #4

Change committed as 107849

Expand Messages | Collapse Messages