Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 8395015: bisect_builds: Don't print '()' after every completed download. (Closed)

Created:
9 years, 2 months ago by Nico
Modified:
9 years, 2 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

bisect_builds: Don't print '()' after every completed download. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107301

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/bisect-builds.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Nico
`print()` prints '()' in python. First to review wins!
9 years, 2 months ago (2011-10-25 19:51:36 UTC) #1
Robert Sesek
lgtm
9 years, 2 months ago (2011-10-25 19:53:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8395015/1
9 years, 2 months ago (2011-10-25 19:57:55 UTC) #3
szager
Um... no. 'print' without parentheses is a no-op. If that's what you want, use 'pass' ...
9 years, 2 months ago (2011-10-25 20:09:50 UTC) #4
Nico
On 2011/10/25 20:09:50, szager wrote: > Um... no. 'print' without parentheses is a no-op. If ...
9 years, 2 months ago (2011-10-25 20:11:17 UTC) #5
Nico
(`print,` is a no-op)
9 years, 2 months ago (2011-10-25 20:11:39 UTC) #6
szager
I stand corrected! python is weird. On Tue, Oct 25, 2011 at 1:11 PM, <thakis@chromium.org> ...
9 years, 2 months ago (2011-10-25 20:14:09 UTC) #7
commit-bot: I haz the power
List of reviewers changed. szager@google.com did a drive-by without LGTM'ing!
9 years, 2 months ago (2011-10-25 22:49:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8395015/1
9 years, 2 months ago (2011-10-25 22:50:13 UTC) #9
commit-bot: I haz the power
Can't apply patch for file tools/bisect-builds.py. While running patch -p1 --forward --force; patching file tools/bisect-builds.py ...
9 years, 2 months ago (2011-10-26 00:20:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8395015/4002
9 years, 2 months ago (2011-10-26 00:23:12 UTC) #11
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-26 01:26:37 UTC) #12
M-A Ruel
On 2011/10/26 01:26:37, I haz the power (commit-bot) wrote: > The commit queue went berserk ...
9 years, 2 months ago (2011-10-26 01:35:31 UTC) #13
M-A Ruel
On 2011/10/26 01:35:31, Marc-Antoine Ruel wrote: > On 2011/10/26 01:26:37, I haz the power (commit-bot) ...
9 years, 2 months ago (2011-10-26 02:28:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8395015/4002
9 years, 2 months ago (2011-10-26 02:28:24 UTC) #15
commit-bot: I haz the power
9 years, 2 months ago (2011-10-26 05:33:30 UTC) #16
Change committed as 107301

Powered by Google App Engine
This is Rietveld 408576698