Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2093)

Unified Diff: chrome/browser/resources/print_preview/header_footer_settings.js

Issue 8395006: Print Preview: Hiding header/footer options when 'no margins' is selected (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebasing Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/print_preview/margin_settings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/print_preview/header_footer_settings.js
diff --git a/chrome/browser/resources/print_preview/header_footer_settings.js b/chrome/browser/resources/print_preview/header_footer_settings.js
index 50b645ed762ad43aefb23b8e1511a1561da43130..be5cef442a190df8ebef63ecc5769759b56d215f 100644
--- a/chrome/browser/resources/print_preview/header_footer_settings.js
+++ b/chrome/browser/resources/print_preview/header_footer_settings.js
@@ -13,6 +13,7 @@ cr.define('print_preview', function() {
function HeaderFooterSettings() {
this.headerFooterOption_ = $('header-footer-option');
this.headerFooterCheckbox_ = $('header-footer');
+ this.headerFooterApplies_ = false;
this.addEventListeners_();
}
@@ -32,7 +33,7 @@ cr.define('print_preview', function() {
* @return {boolean} true if Headers and Footers are checked.
*/
hasHeaderFooter: function() {
- return this.headerFooterCheckbox_.checked;
+ return this.headerFooterApplies_ && this.headerFooterCheckbox_.checked;
},
/**
@@ -44,6 +45,14 @@ cr.define('print_preview', function() {
this.onHeaderFooterChanged_.bind(this);
document.addEventListener(customEvents.PDF_LOADED,
this.onPDFLoaded_.bind(this));
+ document.addEventListener(customEvents.MARGINS_SELECTION_CHANGED,
+ this.onMarginsSelectionChanged_.bind(this));
+ },
+
+ onMarginsSelectionChanged_: function(event) {
+ this.headerFooterApplies_ = event.selectedMargins !=
+ print_preview.MarginSettings.MARGINS_VALUE_NO_MARGINS
+ this.setVisible_(this.headerFooterApplies_);
},
/**
@@ -60,10 +69,20 @@ cr.define('print_preview', function() {
* @private
*/
onPDFLoaded_: function() {
- if (!previewModifiable) {
+ if (!previewModifiable)
+ this.setVisible_(false);
+ },
+
+ /**
+ * Hides or shows |this.headerFooterOption|.
+ * @{param} visible True if |this.headerFooterOption| should be shown.
+ * @private
+ */
+ setVisible_: function(visible) {
+ if (visible)
+ fadeInOption(this.headerFooterOption_);
+ else
fadeOutOption(this.headerFooterOption_);
- this.headerFooterCheckbox_.checked = false;
- }
},
};
« no previous file with comments | « no previous file | chrome/browser/resources/print_preview/margin_settings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698