Store IC data instead of array of classes in AST node, so that we can easier access targets and f...

runtime/vm/compiler.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/compiler.h"
 
 #include "vm/assembler.h"
 #include "vm/ast_printer.h"
 #include "vm/code_generator.h"
 #include "vm/code_index_table.h"
@@ skipping 21 matching lines @@
 // Compile a function. Should call only if the function has not been compiled.
 //   Arg0: function object.
 DEFINE_RUNTIME_ENTRY(CompileFunction, 1) {
   ASSERT(arguments.Count() == kCompileFunctionRuntimeEntry.argument_count());
   const Function& function = Function::CheckedHandle(arguments.At(0));
   ASSERT(!function.HasCode());
   Compiler::CompileFunction(function);
 }
 
 
-// Extracts all encountered classes of instance calls in the unoptimized code
-// by analyzing the inline caches.
-// Each instance call contains a token index which is matched with an AST
-// node. The collected classes are assigned to the corresponding node.
+// Extracts IC data associated with a node id.
+// TODO(srdjan): Check performance impact of node id search loop.
 static void ExtractTypeFeedback(const Code& code,
                                 SequenceNode* sequence_node) {
   ASSERT(!code.IsNull() && !code.is_optimized());
-  GrowableArray<intptr_t> node_ids;
-  GrowableArray<ZoneGrowableArray<const Class*>*> type_arrays;
-  code.ExtractTypesAtIcCalls(&node_ids, &type_arrays);
   GrowableArray<AstNode*> all_nodes;
   sequence_node->CollectAllNodes(&all_nodes);
+  GrowableArray<intptr_t> node_ids;
+  GrowableArray<const Array*> arrays;
+  code.ExtractIcDataArraysAtCalls(&node_ids, &arrays);
   for (intptr_t i = 0; i < node_ids.length(); i++) {
-    ZoneGrowableArray<const Class*>* types = type_arrays[i];
+    intptr_t node_id = node_ids[i];
     bool found_node = false;
     for (intptr_t n = 0; n < all_nodes.length(); n++) {
-      if (all_nodes[n]->HasId(node_ids[i])) {
-        ASSERT(all_nodes[n]->CollectedClassesAtId(node_ids[i]) == NULL);
-        all_nodes[n]->SetCollectedClassesAtId(node_ids[i], types);
+      if (all_nodes[n]->HasId(node_id)) {
         found_node = true;
-        break;
+        // Make sure we assign ic data array only once.
+        ASSERT(all_nodes[n]->ICDataAtId(node_id).NumberOfChecks() == 0);
+        all_nodes[n]->SetIcDataArrayAtId(node_id, *arrays[i]);
       }
     }
-    // There must be a node with the given token index.
     ASSERT(found_node);
   }
 }
 
 
 void Compiler::Compile(const Library& library, const Script& script) {
   if (FLAG_trace_compiler) {
     HANDLESCOPE();
     const String& script_url = String::Handle(script.url());
     // TODO(iposva): Extract script kind.
@@ skipping 191 matching lines @@
                               kNoArgumentNames));
   if (result.IsUnhandledException()) {
     // TODO(srdjan): implement proper exit from compiler.
     UNIMPLEMENTED();
   }
   return result.raw();
 }
 
 
 }  // namespace dart