Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 8394046: [filebrowser] More reliable file saving in Photo Editor (Closed)

Created:
9 years, 1 month ago by Vladislav Kaznacheev
Modified:
9 years, 1 month ago
Reviewers:
kaznacheev, SeRya
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

[filebrowser] More reliable file saving in Photo Editor Photo Editor used to save JPEG files with no metadata as PNG. This is now fixed. Also added simple metadata parsers for PNG/BMP/GIF to make thumbnail display logic in the File Manager work better. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -39 lines) Patch
M chrome/browser/resources/file_manager/js/exif_parser.js View 3 chunks +8 lines, -17 lines 0 comments Download
M chrome/browser/resources/file_manager/js/id3_parser.js View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/resources/file_manager/js/image_editor/image_encoder.js View 1 chunk +3 lines, -3 lines 0 comments Download
A chrome/browser/resources/file_manager/js/image_parsers.js View 1 chunk +93 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/metadata_dispatcher.js View 6 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/resources/file_manager/js/metadata_parser.js View 2 chunks +25 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/mpeg_parser.js View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Vladislav Kaznacheev
9 years, 1 month ago (2011-10-26 12:58:55 UTC) #1
SeRya
On 2011/10/26 12:58:55, Vladislav Kaznacheev wrote: LGTM
9 years, 1 month ago (2011-10-27 12:09:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8394046/1
9 years, 1 month ago (2011-10-27 12:13:20 UTC) #3
commit-bot: I haz the power
Change committed as 107561
9 years, 1 month ago (2011-10-27 13:20:31 UTC) #4
Peter Mayo
On 2011/10/27 13:20:31, I haz the power (commit-bot) wrote: > Change committed as 107561 http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/builds/965 ...
9 years, 1 month ago (2011-10-27 13:55:44 UTC) #5
kaznacheev
I did not expect that, but it very well might be related. Shall I revert ...
9 years, 1 month ago (2011-10-27 14:03:06 UTC) #6
Peter Mayo
9 years, 1 month ago (2011-10-27 14:51:11 UTC) #7
On 2011/10/27 14:03:06, kaznacheev_google.com wrote:
> I did not expect that, but it very well might be related. Shall I revert it?
> 
>   Vlad
> 
Revert or fix ...  depends where you are in your day/confidence/etc.

Peter.

Powered by Google App Engine
This is Rietveld 408576698