Pass through installer errors from Google Update to the About box.

Pass through installer errors from Google Update to the About box.

BUG=96477
TEST=You either need to find a way to manually make the upgrade through the About box fail or get a custom Google Update that returns an error during upgrade (see Ganesh). It is also important to make sure Chromium builds still refuse to update and obviously to make sure the update process through the About box still works.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108106

[Finnur, 2011-10-26 13:19:58]

Do you mind taking this, Carlos? It is worse than it looks (mostly plumbing and
wstring->string16 changes).

[grt (UTC plus 2), 2011-10-26 14:35:55]

drive-by meta-comment about wstring -> string16 changes: it seems to me that
FilePath::StringType is more appropriate than string16 for path-like strings
(especially those originating from a FilePath instance's value() method).  is
there a reason not to use it?  apologies if this has been discussed to death and
i missed the exciting conclusion.

http://codereview.chromium.org/8394042/diff/1/chrome/browser/google/google_up...
File chrome/browser/google/google_update.h (right):

http://codereview.chromium.org/8394042/diff/1/chrome/browser/google/google_up...
chrome/browser/google/google_update.h:76: const string16& error_string,
nit: is this the same thing that's called |error_message| below?  if so, please
use the same name.

[Finnur, 2011-10-26 15:25:11]

> drive-by meta-comment about wstring -> string16 changes:
> apologies if this has been discussed to death and
> i missed the exciting conclusion.

I see that a massive change to convert to FilePath failed on the bots and was
reverted, and apparently not tried again. The logs are long lost, but I see talk
of compile failures and test failures, so I suspect it was not related to this
piece of code. 

So I converted it to FilePath, which is what it should have been in the first
place, I believe. This code is old and untouched for a long while so it probably
predated the FilePath class. Please review the FilePath changes extra
critically, since this is pretty important to get right.

http://codereview.chromium.org/8394042/diff/1/chrome/browser/google/google_up...
File chrome/browser/google/google_update.h (right):

http://codereview.chromium.org/8394042/diff/1/chrome/browser/google/google_up...
chrome/browser/google/google_update.h:76: const string16& error_string,
Good catch.

[grt (UTC plus 2), 2011-10-26 17:49:06]

FilePath changes LGTM.

[S. Ganesh, 2011-10-26 21:47:35]

http://codereview.chromium.org/8394042/diff/4001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8394042/diff/4001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:5106: Unable to contact Google Update.
Would be good to include the hex HRESULT here, such as 0x80040154.

http://codereview.chromium.org/8394042/diff/4001/chrome/browser/google/google...
File chrome/browser/google/google_update.cc (right):

http://codereview.chromium.org/8394042/diff/4001/chrome/browser/google/google...
chrome/browser/google/google_update.cc:205: // Returns which version Google
Update found on the server (if a more
Comment is incorrect.

[Finnur, 2011-10-27 16:14:28]

Carlos, ping?

Ganesh, good points. Addressed.

On 2011/10/26 21:47:35, ganesh wrote:
>
http://codereview.chromium.org/8394042/diff/4001/chrome/app/generated_resourc...
> File chrome/app/generated_resources.grd (right):
> 
>
http://codereview.chromium.org/8394042/diff/4001/chrome/app/generated_resourc...
> chrome/app/generated_resources.grd:5106: Unable to contact Google Update.
> Would be good to include the hex HRESULT here, such as 0x80040154.
> 
>
http://codereview.chromium.org/8394042/diff/4001/chrome/browser/google/google...
> File chrome/browser/google/google_update.cc (right):
> 
>
http://codereview.chromium.org/8394042/diff/4001/chrome/browser/google/google...
> chrome/browser/google/google_update.cc:205: // Returns which version Google
> Update found on the server (if a more
> Comment is incorrect.

[cpu_(ooo_6.6-7.5), 2011-10-28 02:58:24]

lgtm